Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp

Issue 494133002: Append "Callback" to each value of enum CallbackType (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/core/v8/V8HiddenValue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp
diff --git a/Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp b/Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp
index 0e2a9cb0eaf1bf736e0734dc05dc14f5b40819c5..b4fbfa45f0dd6907e76f0d24b90dfaabe1ce53a5 100644
--- a/Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp
+++ b/Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp
@@ -44,11 +44,11 @@
namespace blink {
-#define CALLBACK_LIST(V) \
- V(created, Created) \
- V(attached, Attached) \
- V(detached, Detached) \
- V(attributeChanged, AttributeChanged)
+#define CALLBACK_LIST(V) \
+ V(created, CreatedCallback) \
+ V(attached, AttachedCallback) \
+ V(detached, DetachedCallback) \
+ V(attributeChanged, AttributeChangedCallback)
PassRefPtr<V8CustomElementLifecycleCallbacks> V8CustomElementLifecycleCallbacks::create(ScriptState* scriptState, v8::Handle<v8::Object> prototype, v8::Handle<v8::Function> created, v8::Handle<v8::Function> attached, v8::Handle<v8::Function> detached, v8::Handle<v8::Function> attributeChanged)
{
@@ -69,16 +69,16 @@ PassRefPtr<V8CustomElementLifecycleCallbacks> V8CustomElementLifecycleCallbacks:
static CustomElementLifecycleCallbacks::CallbackType flagSet(v8::Handle<v8::Function> attached, v8::Handle<v8::Function> detached, v8::Handle<v8::Function> attributeChanged)
{
// V8 Custom Elements always run created to swizzle prototypes.
- int flags = CustomElementLifecycleCallbacks::Created;
+ int flags = CustomElementLifecycleCallbacks::CreatedCallback;
if (!attached.IsEmpty())
- flags |= CustomElementLifecycleCallbacks::Attached;
+ flags |= CustomElementLifecycleCallbacks::AttachedCallback;
if (!detached.IsEmpty())
- flags |= CustomElementLifecycleCallbacks::Detached;
+ flags |= CustomElementLifecycleCallbacks::DetachedCallback;
if (!attributeChanged.IsEmpty())
- flags |= CustomElementLifecycleCallbacks::AttributeChanged;
+ flags |= CustomElementLifecycleCallbacks::AttributeChangedCallback;
return CustomElementLifecycleCallbacks::CallbackType(flags);
}
« no previous file with comments | « no previous file | Source/bindings/core/v8/V8HiddenValue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698