Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 494093003: On tapping the disabled option in context menu should not close the menu (Closed)

Created:
6 years, 4 months ago by divya.bansal
Modified:
6 years, 3 months ago
Reviewers:
Ted C, lgombos
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

On tapping the disabled option in context menu should not close the menu In the context menu, disabled items are not required so can be removed instead of disabling them, so user donot tap on it. BUG=395551 Committed: https://crrev.com/0ab900d27b873f51c248338a043d43ac253d43bb Cr-Commit-Position: refs/heads/master@{#291861}

Patch Set 1 #

Patch Set 2 : Adding name in Authors file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
divya.bansal
PTAL
6 years, 4 months ago (2014-08-22 09:21:51 UTC) #1
Ted C
On 2014/08/22 09:21:51, divya.bansal wrote: > PTAL Before I can approve this change, you need ...
6 years, 4 months ago (2014-08-22 16:59:51 UTC) #2
lgombos
On 2014/08/22 16:59:51, Ted C wrote: > On 2014/08/22 09:21:51, divya.bansal wrote: > > PTAL ...
6 years, 4 months ago (2014-08-22 19:30:15 UTC) #3
divya.bansal
On 2014/08/22 19:30:15, lgombos wrote: > On 2014/08/22 16:59:51, Ted C wrote: > > On ...
6 years, 4 months ago (2014-08-25 04:37:41 UTC) #4
Ted C
lgtm
6 years, 4 months ago (2014-08-25 20:07:41 UTC) #5
divya.bansal
The CQ bit was checked by divya.bansal@samsung.com
6 years, 4 months ago (2014-08-26 05:05:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/divya.bansal@samsung.com/494093003/20001
6 years, 4 months ago (2014-08-26 05:07:25 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-26 05:57:46 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (20001) as 4c0f1e826069f8416b8acbeeb17807b193fa01b4
6 years, 4 months ago (2014-08-26 07:40:12 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:41:12 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0ab900d27b873f51c248338a043d43ac253d43bb
Cr-Commit-Position: refs/heads/master@{#291861}

Powered by Google App Engine
This is Rietveld 408576698