Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

Issue 494093003: On tapping the disabled option in context menu should not close the menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding name in Authors file Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
index 550d54d97ecd37c5a0a08fb20130bce017ea4f87..186fec98f008dd61b421fe2afc0b1f505d25aa6e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
@@ -58,14 +58,14 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {
menu.findItem(R.id.contextmenu_copy_link_text).setVisible(false);
}
- menu.findItem(R.id.contextmenu_save_link_as).setEnabled(
+ menu.findItem(R.id.contextmenu_save_link_as).setVisible(
UrlUtilities.isDownloadableScheme(params.getLinkUrl()));
if (params.isVideo()) {
- menu.findItem(R.id.contextmenu_save_video).setEnabled(
+ menu.findItem(R.id.contextmenu_save_video).setVisible(
UrlUtilities.isDownloadableScheme(params.getSrcUrl()));
} else if (params.isImage()) {
- menu.findItem(R.id.contextmenu_save_image).setEnabled(
+ menu.findItem(R.id.contextmenu_save_image).setVisible(
UrlUtilities.isDownloadableScheme(params.getSrcUrl()));
if (mDelegate.canLoadOriginalImage()) {
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698