Issue 494063002: Rename IsDontDelete to IsConfigurable (and invert conditions)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 494063002: Rename IsDontDelete to IsConfigurable (and invert conditions) (Closed)

Created:
6 years, 4 months ago by Toon Verwaest

Modified:
6 years, 4 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Rename IsDontDelete to IsConfigurable (and invert conditions) BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23267

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -15 lines)			Patch
M	src/elements.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen-instructions.h	View	1 chunk	+1 line, -3 lines	1 comment	Download
M	src/hydrogen-instructions.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/lookup.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/property.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/property-details.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

PTAL https://codereview.chromium.org/494063002/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/494063002/diff/1/src/hydrogen-instructions.h#newcode5796 src/hydrogen-instructions.h:5796: bool RequiresHoleCheck() { return details_.IsConfigurable(); } I removed ...

6 years, 4 months ago (2014-08-21 08:53:23 UTC) #1

Toon Verwaest

6 years, 4 months ago (2014-08-21 09:34:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 23267 (presubmit successful).

Expand Messages | Collapse Messages