Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1916)

Issue 494033002: Move AppWindow to extensions (Closed)

Created:
6 years, 4 months ago by hashimoto
Modified:
6 years, 3 months ago
Reviewers:
benwells, sky
CC:
chromium-reviews, vandebo (ex-Chrome), sadrul, nkostylev+watch_chromium.org, tzik, posciak+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, stevenjb+watch_chromium.org, extensions-reviews_chromium.org, benquan, Ilya Sherman, chromium-apps-reviews_chromium.org, Dane Wallinga, dbeam+watch-options_chromium.org, dyu1, nhiroki, feature-media-reviews_chromium.org, oshima+watch_chromium.org, kalyank, rouslan+autofillwatch_chromium.org, chrome-apps-syd-reviews_chromium.org, Lei Zhang, tfarina, mcasas+watch_chromium.org, tommycli, davemoore+watch_chromium.org, Greg Billock, estade+watch_chromium.org, wjia+watch_chromium.org, kinuko+fileapi, ben+ash_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move AppWindow to extensions Move AppWindow, AppWindowRegistry and AppsClient from apps/ to extensions/browser/app_window Change the namespace from apps to extensions. Fix GYP and DEPS. BUG=403726 TBR=sky@chromium.org for include and namespace changes Committed: https://crrev.com/ad3c6870f41f0b057697ea8dec59cc8cf8108745 Cr-Commit-Position: refs/heads/master@{#292599}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : Fix GN #

Patch Set 4 : rebase #

Total comments: 2

Patch Set 5 : rebase #

Patch Set 6 : Add TODO #

Patch Set 7 : Remove unneeded include in chrome_shell_delegate.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+655 lines, -3226 lines) Patch
M apps/BUILD.gn View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M apps/app_lifetime_monitor.h View 3 chunks +7 lines, -7 lines 0 comments Download
M apps/app_lifetime_monitor.cc View 1 chunk +3 lines, -1 line 0 comments Download
M apps/app_lifetime_monitor_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M apps/app_load_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M apps/app_load_service_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M apps/app_restore_service.h View 1 chunk +1 line, -1 line 0 comments Download
M apps/app_restore_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M apps/app_shim/app_shim_handler_mac.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M apps/app_shim/extension_app_shim_handler_mac.h View 4 chunks +9 lines, -9 lines 0 comments Download
M apps/app_shim/extension_app_shim_handler_mac.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M apps/app_shim/extension_app_shim_handler_mac_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D apps/app_window.h View 1 1 chunk +0 lines, -560 lines 0 comments Download
D apps/app_window.cc View 1 1 chunk +0 lines, -1099 lines 0 comments Download
M apps/app_window_browsertest.cc View 1 chunk +0 lines, -82 lines 0 comments Download
M apps/app_window_contents.h View 3 chunks +4 lines, -4 lines 0 comments Download
M apps/app_window_contents.cc View 1 chunk +1 line, -0 lines 0 comments Download
M apps/app_window_interactive_uitest.cc View 1 chunk +0 lines, -190 lines 0 comments Download
D apps/app_window_registry.h View 1 chunk +0 lines, -160 lines 0 comments Download
D apps/app_window_registry.cc View 1 chunk +0 lines, -353 lines 0 comments Download
M apps/apps.gypi View 1 2 chunks +0 lines, -6 lines 0 comments Download
D apps/ui/apps_client.h View 1 chunk +0 lines, -64 lines 0 comments Download
D apps/ui/apps_client.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M apps/ui/views/native_app_window_views.h View 4 chunks +9 lines, -8 lines 0 comments Download
M apps/ui/views/native_app_window_views.cc View 2 chunks +3 lines, -1 line 0 comments Download
M athena/activity/public/activity_factory.h View 1 2 3 2 chunks +2 lines, -5 lines 0 comments Download
M athena/content/content_activity_factory.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M athena/content/shell/content_activity_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M athena/test/sample_activity_factory.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M athena/test/sample_activity_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/app_controller_mac.mm View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/app_controller_mac_browsertest.mm View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/apps/app_browsertest.cc View 1 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/apps/app_browsertest_util.h View 5 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/apps/app_browsertest_util.cc View 4 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/apps/app_window_interactive_uitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/apps/ephemeral_app_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/event_page_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/web_view_browsertest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/apps/web_view_interactive_browsertest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/app_session_lifetime.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/app_launch_controller.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 1 4 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/test/app_window_waiter.h View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/test/app_window_waiter.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 1 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.h View 17 chunks +19 lines, -21 lines 0 comments Download
M chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/app_window/app_window_api.h View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/app_window/app_window_api.cc View 10 chunks +11 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/app_window/app_window_apitest.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_browsertest.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 1 2 3 5 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/identity/web_auth_flow.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/identity/web_auth_flow.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_api.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/tabs/ash_panel_contents.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/tabs/ash_panel_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/startup_helper.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/window_open_apitest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media/media_capture_devices_dispatcher.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 3 4 chunks +16 lines, -14 lines 0 comments Download
M chrome/browser/power/process_power_collector.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/power/process_power_collector_unittest.cc View 1 2 3 4 5 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/ui/apps/apps_metro_handler_win.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/apps/chrome_apps_client.h View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/apps/chrome_apps_client.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/accelerator_commands_browsertest.cc View 6 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/app_window_launcher_controller.h View 6 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/ui/ash/launcher/app_window_launcher_controller.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h View 3 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 1 8 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_win.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/multi_profile_app_window_launcher_controller.h View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/launcher/multi_profile_app_window_launcher_controller.cc View 9 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/ui/ash/media_delegate_chromeos.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 6 chunks +15 lines, -13 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 2 3 4 4 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.mm View 1 3 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm View 4 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/chrome_apps_client_cocoa.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h View 3 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm View 11 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac_interactive_uitest.cc View 6 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_controller_delegate_win.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_apps_client_views.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_apps_client_views_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/options_handlers_helper.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/website_settings_handler.cc View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/testing_browser_process.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/BUILD.gn View 1 2 chunks +7 lines, -0 lines 0 comments Download
M extensions/browser/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A + extensions/browser/app_window/app_window.h View 1 13 chunks +25 lines, -30 lines 0 comments Download
A + extensions/browser/app_window/app_window.cc View 1 30 chunks +53 lines, -62 lines 0 comments Download
A + extensions/browser/app_window/app_window_browsertest.cc View 2 chunks +3 lines, -6 lines 0 comments Download
A + extensions/browser/app_window/app_window_interactive_uitest.cc View 2 chunks +2 lines, -5 lines 0 comments Download
A + extensions/browser/app_window/app_window_registry.h View 8 chunks +26 lines, -27 lines 0 comments Download
A + extensions/browser/app_window/app_window_registry.cc View 5 chunks +9 lines, -10 lines 0 comments Download
A + extensions/browser/app_window/apps_client.h View 1 2 3 4 5 3 chunks +12 lines, -13 lines 0 comments Download
A + extensions/browser/app_window/apps_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/extensions.gyp View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
hashimoto
Patchset #1 (id:60001) has been deleted
6 years, 3 months ago (2014-08-27 04:17:03 UTC) #1
hashimoto
hashimoto@chromium.org changed reviewers: + benwells@chromium.org
6 years, 3 months ago (2014-08-27 04:23:25 UTC) #2
hashimoto
Please review. Sorry for sending a huge CL like this. These 3 classes should be ...
6 years, 3 months ago (2014-08-27 04:23:25 UTC) #3
benwells
lgtm https://codereview.chromium.org/494033002/diff/140001/extensions/browser/app_window/apps_client.h File extensions/browser/app_window/apps_client.h (right): https://codereview.chromium.org/494033002/diff/140001/extensions/browser/app_window/apps_client.h#newcode25 extensions/browser/app_window/apps_client.h:25: class AppsClient { Could you add a TODO ...
6 years, 3 months ago (2014-08-29 06:09:14 UTC) #4
hashimoto
https://codereview.chromium.org/494033002/diff/140001/extensions/browser/app_window/apps_client.h File extensions/browser/app_window/apps_client.h (right): https://codereview.chromium.org/494033002/diff/140001/extensions/browser/app_window/apps_client.h#newcode25 extensions/browser/app_window/apps_client.h:25: class AppsClient { On 2014/08/29 06:09:14, benwells wrote: > ...
6 years, 3 months ago (2014-08-29 07:06:55 UTC) #5
hashimoto
hashimoto@chromium.org changed reviewers: + sky@chromium.org
6 years, 3 months ago (2014-08-29 07:17:10 UTC) #6
hashimoto
TBRing sky@chromium.org for include and namespace changes
6 years, 3 months ago (2014-08-29 07:17:29 UTC) #7
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 3 months ago (2014-08-29 07:17:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/494033002/200001
6 years, 3 months ago (2014-08-29 07:18:22 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-29 08:49:52 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-29 09:02:23 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/10357)
6 years, 3 months ago (2014-08-29 09:02:26 UTC) #12
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 3 months ago (2014-08-29 09:05:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/494033002/200001
6 years, 3 months ago (2014-08-29 09:05:55 UTC) #14
commit-bot: I haz the power
Committed patchset #7 (id:200001) as 6d1a0c4f62f5ac2e403b0b61889a3840f9cf2fd0
6 years, 3 months ago (2014-08-29 09:47:14 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:07:27 UTC) #16
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/ad3c6870f41f0b057697ea8dec59cc8cf8108745
Cr-Commit-Position: refs/heads/master@{#292599}

Powered by Google App Engine
This is Rietveld 408576698