Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: extensions/browser/app_window/apps_client.h

Issue 494033002: Move AppWindow to extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove unneeded include in chrome_shell_delegate.cc Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/app_window/app_window_registry.cc ('k') | extensions/browser/app_window/apps_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/app_window/apps_client.h
diff --git a/apps/ui/apps_client.h b/extensions/browser/app_window/apps_client.h
similarity index 71%
rename from apps/ui/apps_client.h
rename to extensions/browser/app_window/apps_client.h
index f601e679a9f6dba2ff410a74f91640b68e71b7f2..7743b006394b3a48ac984b3d31e113733cc6036d 100644
--- a/apps/ui/apps_client.h
+++ b/extensions/browser/app_window/apps_client.h
@@ -2,13 +2,13 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef APPS_UI_APPS_CLIENT_H_
-#define APPS_UI_APPS_CLIENT_H_
+#ifndef EXTENSIONS_BROWSER_APP_WINDOW_APPS_CLIENT_H_
+#define EXTENSIONS_BROWSER_APP_WINDOW_APPS_CLIENT_H_
#include <vector>
-#include "apps/app_window.h"
#include "base/callback_forward.h"
+#include "extensions/browser/app_window/app_window.h"
namespace content {
class BrowserContext;
@@ -16,27 +16,26 @@ class WebContents;
}
namespace extensions {
+
class Extension;
class NativeAppWindow;
-}
-
-namespace apps {
// Sets up global state for the apps system. Should be Set() once in each
// process. This should be implemented by the client of the apps system.
+// TODO(hashimoto): Move some functions to ExtensionsClient and rename this to
+// AppWindowClient.
class AppsClient {
public:
// Get all loaded browser contexts.
virtual std::vector<content::BrowserContext*> GetLoadedBrowserContexts() = 0;
- // Creates a new apps::AppWindow for the app in |extension| for |context|.
+ // Creates a new AppWindow for the app in |extension| for |context|.
// Caller takes ownership.
- virtual AppWindow* CreateAppWindow(
- content::BrowserContext* context,
- const extensions::Extension* extension) = 0;
+ virtual AppWindow* CreateAppWindow(content::BrowserContext* context,
+ const Extension* extension) = 0;
// Creates a new extensions::NativeAppWindow for |window|.
- virtual extensions::NativeAppWindow* CreateNativeAppWindow(
+ virtual NativeAppWindow* CreateNativeAppWindow(
AppWindow* window,
const AppWindow::CreateParams& params) = 0;
@@ -59,6 +58,6 @@ class AppsClient {
static void Set(AppsClient* client);
};
-} // namespace apps
+} // namespace extensions
-#endif // APPS_UI_APPS_CLIENT_H_
+#endif // EXTENSIONS_BROWSER_APP_WINDOW_APPS_CLIENT_H_
« no previous file with comments | « extensions/browser/app_window/app_window_registry.cc ('k') | extensions/browser/app_window/apps_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698