Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 493803002: [Mac] With the new avatar button, tabs do not expand to fill bar in fullscreen (Closed)

Created:
6 years, 4 months ago by noms (inactive)
Modified:
6 years, 4 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

[Mac] With the new avatar button, tabs do not expand to fill bar in fullscreen When in fullscreen we should give back the fullscreen icon's width to the tabstrip. Before: https://drive.google.com/open?id=0B1B1Up4p2NRMdXloQ3phSElBeEk&authuser=1 After: https://drive.google.com/open?id=0B1B1Up4p2NRMM2JNRE56aC1uRDA&authuser=1 BUG=403561 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291162

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
noms (inactive)
Hiya, Fixed a small issue when rendering the new avatar button, where in fullscreen mode ...
6 years, 4 months ago (2014-08-20 18:47:16 UTC) #1
Robert Sesek
lgtm
6 years, 4 months ago (2014-08-20 19:07:53 UTC) #2
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 4 months ago (2014-08-20 19:31:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/493803002/1
6 years, 4 months ago (2014-08-20 19:31:55 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-20 20:49:49 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 20:53:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/55067) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg/builds/7883)
6 years, 4 months ago (2014-08-20 20:53:20 UTC) #7
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 4 months ago (2014-08-21 14:21:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/493803002/1
6 years, 4 months ago (2014-08-21 14:23:41 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 20:24:31 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (1) as 291162

Powered by Google App Engine
This is Rietveld 408576698