Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3999)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 493803002: [Mac] With the new avatar button, tabs do not expand to fill bar in fullscreen (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
index 664ca9550b0745404668322066b197e43ed47eef..f02b5eb5b337d89e801b85c7cee46bd36d4d487c 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
@@ -357,10 +357,16 @@ willPositionSheet:(NSWindow*)sheet
static_cast<FramedBrowserWindow*>([self window]);
rightIndent += -[window fullScreenButtonOriginAdjustment].x;
- // The new avatar is wider than the default indentation, so we need to
- // account for its width.
- if ([self shouldUseNewAvatarButton])
+ if ([self shouldUseNewAvatarButton]) {
+ // The new avatar is wider than the default indentation, so we need to
+ // account for its width.
rightIndent += NSWidth([avatarButton frame]) + kAvatarTabStripShrink;
+
+ // When the fullscreen icon is not displayed, return its width to the
+ // tabstrip.
+ if ([self isFullscreen])
+ rightIndent -= kFullscreenIconWidth;
+ }
} else if ([self shouldShowAvatar]) {
rightIndent += kAvatarTabStripShrink +
NSWidth([avatarButton frame]) + kAvatarRightOffset;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698