Add way to reload the page, ignoring the cache

content/browser/android/content_view_core_impl.cc

Index: content/browser/android/content_view_core_impl.cc
diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc
index c423adb26a525acca2f5cb89f0401acbcca22de2..032555a9d1dd8e3b981de6f855e6d02dab4a46ab 100644
--- a/content/browser/android/content_view_core_impl.cc
+++ b/content/browser/android/content_view_core_impl.cc
@@ -1200,10 +1200,12 @@ void ContentViewCoreImpl::StopLoading(JNIEnv* env, jobject obj) {
   web_contents_->Stop();
 }
 
-void ContentViewCoreImpl::Reload(JNIEnv* env, jobject obj) {
-  // Set check_for_repost parameter to false as we have no repost confirmation
-  // dialog ("confirm form resubmission" screen will still appear, however).
-  if (web_contents_->GetController().NeedsReload())
+void ContentViewCoreImpl::Reload(JNIEnv* env,
+                                 jobject obj,
+                                 jboolean ignore_cache) {
+  if (ignore_cache)
+    web_contents_->GetController().ReloadIgnoringCache(true);
+  else if (web_contents_->GetController().NeedsReload())

[joth, 2013/11/06 19:57:28]

nit: use {} on if else ladder

[gone, 2013/11/06 21:24:35]

Done.

     web_contents_->GetController().LoadIfNecessary();

[joth, 2013/11/06 19:57:28]

this is counter intuitive: if we "need a reload" we load, otherwise we reload.

add a comment to explain overall reasoning on this function?

[gone, 2013/11/06 21:24:35]

Don't know the reasoning :/  I do know that the comment is out of date, though,
so that got taken out.

dtrainor/tedchoc: Should the ignore cache reload be part of the else clause
here, instead?  Seems like the NeedsReload() call indicates that the navigation
controller is about to restore a session, clone a tab, or had their renderers
killed.

[Ted C, 2013/11/06 21:38:14]

At least in the past, Reload didn't work for session restored tabs, so we needed
to branch like this.  Here's the change where it was introduced (by me, but I
must admit I don't really recall more indepth reasoning behind that):
https://chromiumcodereview.appspot.com/11293025/

Now that you bring this up, I don't know if the NeedsReload/LoadIfNecessary will
do a cache ignoring load or not, but maybe this check should go first.

   else
     web_contents_->GetController().Reload(true);