Add way to reload the page, ignoring the cache

content/browser/android/content_view_core_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/content_view_core_impl.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/android/scoped_java_ref.h"
@@ skipping 1182 matching lines @@
 }
 
 void ContentViewCoreImpl::RequestRestoreLoad(JNIEnv* env, jobject obj) {
   web_contents_->GetController().SetNeedsReload();
 }
 
 void ContentViewCoreImpl::StopLoading(JNIEnv* env, jobject obj) {
   web_contents_->Stop();
 }
 
-void ContentViewCoreImpl::Reload(JNIEnv* env, jobject obj) {
-  // Set check_for_repost parameter to false as we have no repost confirmation
-  // dialog ("confirm form resubmission" screen will still appear, however).
-  if (web_contents_->GetController().NeedsReload())
+void ContentViewCoreImpl::Reload(JNIEnv* env,
+                                 jobject obj,
+                                 jboolean ignore_cache) {
+  if (ignore_cache)
+    web_contents_->GetController().ReloadIgnoringCache(true);
+  else if (web_contents_->GetController().NeedsReload())

[joth, 2013/11/06 19:57:28]

nit: use {} on if else ladder

[gone, 2013/11/06 21:24:35]

Done.

     web_contents_->GetController().LoadIfNecessary();

[joth, 2013/11/06 19:57:28]

this is counter intuitive: if we "need a reload" we load, otherwise we reload.

add a comment to explain overall reasoning on this function?

[gone, 2013/11/06 21:24:35]

Don't know the reasoning :/  I do know that the comment is out of date, though,
so that got taken out.

dtrainor/tedchoc: Should the ignore cache reload be part of the else clause
here, instead?  Seems like the NeedsReload() call indicates that the navigation
controller is about to restore a session, clone a tab, or had their renderers
killed.

[Ted C, 2013/11/06 21:38:14]

At least in the past, Reload didn't work for session restored tabs, so we needed
to branch like this.  Here's the change where it was introduced (by me, but I
must admit I don't really recall more indepth reasoning behind that):
https://chromiumcodereview.appspot.com/11293025/

Now that you bring this up, I don't know if the NeedsReload/LoadIfNecessary will
do a cache ignoring load or not, but maybe this check should go first.

   else
     web_contents_->GetController().Reload(true);
   UpdateTabCrashedFlag();
 }
 
 void ContentViewCoreImpl::CancelPendingReload(JNIEnv* env, jobject obj) {
   web_contents_->GetController().CancelPendingReload();
 }
 
 void ContentViewCoreImpl::ContinuePendingReload(JNIEnv* env, jobject obj) {
@@ skipping 424 matching lines @@
       reinterpret_cast<ui::ViewAndroid*>(view_android),
       reinterpret_cast<ui::WindowAndroid*>(window_android));
   return reinterpret_cast<jint>(view);
 }
 
 bool RegisterContentViewCore(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace content