Issue 49353005: Make all PDF-related file extensions non-"dangerous".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 49353005: Make all PDF-related file extensions non-"dangerous". (Closed)

Created:
7 years, 1 month ago by palmer

Modified:
7 years, 1 month ago

Reviewers:
asanka, felt

CC:
Peter Kasting, jam, chromium-reviews, benjhayden+dwatch_chromium.org, asanka, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make all PDF-related file extensions non-"dangerous". BUG=148492 TEST=When downloading a file with a PDF-related extension, ensure that you never get the "this file is dangerous" warning. The PDF-related extensions are: pdf, pdfxml, mars, fdf, xfdf, xdp, and xfd. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231756

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
	M	chrome/browser/download/download_extensions.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

palmer

pkasting wanted us to make no PDf-related extension dangerous, and jam wanted us to treat ...

7 years, 1 month ago (2013-10-28 23:04:29 UTC) #1

asanka

LGTM Update the TEST= line. Downloads of .pdf files aren't affected by this change.

7 years, 1 month ago (2013-10-29 14:39:05 UTC) #2

palmer

> Update the TEST= line. Downloads of .pdf files aren't affected by this change. Done.

7 years, 1 month ago (2013-10-29 21:04:00 UTC) #3

felt

I honestly have no idea what these other extensions are but if they are PDF-related ...

7 years, 1 month ago (2013-10-29 21:04:39 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/49353005/1

7 years, 1 month ago (2013-10-30 00:26:19 UTC) #5

Message was sent while issue was closed.

Change committed as 231756

Expand Messages | Collapse Messages