Issue 493383003: Revert 291388 "Rename appcache/manifest_parser* to appcache/appc..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 493383003: Revert 291388 "Rename appcache/manifest_parser* to appcache/appc..." (Closed)

Created:
6 years, 4 months ago by pauljensen

Modified:
6 years, 4 months ago

Reviewers:
mlamouri (slow - plz ping)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 291388 "Rename appcache/manifest_parser* to appcache/appc..." Fails check_licenses > Rename appcache/manifest_parser* to appcache/appcache_manifest_parser*. > > The manifest_parser.{h,cc} files are colliding with new files I'm > creating for the Web Manifest feature. Appcache manifest files should > be prefixed by "appcache". > > BUG=None > NOTRY=true > > Review URL: https://codereview.chromium.org/469413003 TBR=mlamouri@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291391

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -971 lines)			Patch
M	trunk/src/content/browser/appcache/appcache.h	View	1 chunk	+1 line, -1 line	0 comments	Download
D	trunk/src/content/browser/appcache/appcache_manifest_parser.h	View	1 chunk	+0 lines, -72 lines	0 comments	Download
D	trunk/src/content/browser/appcache/appcache_manifest_parser.cc	View	1 chunk	+0 lines, -382 lines	0 comments	Download
D	trunk/src/content/browser/appcache/appcache_manifest_parser_unittest.cc	View	1 chunk	+0 lines, -516 lines	0 comments	Download
A +	trunk/src/content/browser/appcache/manifest_parser.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/content/browser/appcache/manifest_parser.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/content/browser/appcache/manifest_parser_unittest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/content/content_browser.gypi	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/content/content_tests.gypi	View	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pauljensen

6 years, 4 months ago (2014-08-22 13:03:43 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r291391 (tree was closed).

Expand Messages | Collapse Messages