Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 469413003: Rename appcache/manifest_parser* to appcache/appcache_manifest_parser*. (Closed)

Created:
6 years, 4 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 4 months ago
Reviewers:
michaeln, Torne
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename appcache/manifest_parser* to appcache/appcache_manifest_parser*. The manifest_parser.{h,cc} files are colliding with new files I'm creating for the Web Manifest feature. Appcache manifest files should be prefixed by "appcache". BUG=None NOTRY=true TBR=torne (for third_party_files_whitelist.txt) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291388 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291393

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : update third_party_files_whitelist.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -981 lines) Patch
M android_webview/tools/third_party_files_whitelist.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/appcache/appcache.h View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/appcache/appcache_manifest_parser.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/appcache/appcache_manifest_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/appcache/appcache_manifest_parser_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/appcache/manifest_parser.h View 1 chunk +0 lines, -72 lines 0 comments Download
D content/browser/appcache/manifest_parser.cc View 1 chunk +0 lines, -382 lines 0 comments Download
D content/browser/appcache/manifest_parser_unittest.cc View 1 chunk +0 lines, -516 lines 0 comments Download
M content/content_browser.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 2 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (0 generated)
mlamouri (slow - plz ping)
6 years, 4 months ago (2014-08-20 09:49:04 UTC) #1
michaeln
lgtm
6 years, 4 months ago (2014-08-20 20:34:30 UTC) #2
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 4 months ago (2014-08-21 08:05:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/469413003/1
6 years, 4 months ago (2014-08-21 08:06:52 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-21 09:19:50 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 09:21:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/5231)
6 years, 4 months ago (2014-08-21 09:21:10 UTC) #7
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 4 months ago (2014-08-21 13:13:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/469413003/20001
6 years, 4 months ago (2014-08-21 13:14:55 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-21 17:55:57 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 17:58:47 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/5810)
6 years, 4 months ago (2014-08-21 17:58:48 UTC) #12
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 4 months ago (2014-08-22 12:49:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/469413003/20001
6 years, 4 months ago (2014-08-22 12:50:14 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (20001) as 291388
6 years, 4 months ago (2014-08-22 12:51:41 UTC) #15
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 4 months ago (2014-08-22 13:13:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/469413003/40001
6 years, 4 months ago (2014-08-22 13:14:18 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (40001) as 291393
6 years, 4 months ago (2014-08-22 13:15:12 UTC) #18
pauljensen
What is the motivation for NOTRY=true?
6 years, 4 months ago (2014-08-22 13:28:36 UTC) #19
mlamouri (slow - plz ping)
6 years, 4 months ago (2014-08-22 13:45:51 UTC) #20
Message was sent while issue was closed.
On 2014/08/22 13:28:36, pauljensen wrote:
> What is the motivation for NOTRY=true?

The move is triggering presubmit warning related to the content of the file. The
intent of this CL isn't to fix the content of the files but just rename them.

Powered by Google App Engine
This is Rietveld 408576698