Chromium Code Reviews Chromium Code Reviews
Issue
493363002:
create sk_tools::Expectation class, similar to skiagm::Expectations class (Closed)
Descriptioncreate sk_tools::Expectation class, similar to skiagm::Expectations class
The overarching goal here is for our "gm" and "render_pictures" tools to handle
image expectations/actuals in the same way, sharing the same code, so their
results can be processed through a single pipeline.
By adding an Expectation class within tools/image_expectations.h, similar to
the Expectations class in gm/gm_expectations.h, we get one step closer to
that goal.
TBR=stephana
Committed: https://skia.googlesource.com/skia/+/85b438dfab7f6ec1fd46dbc19215ccf2171ad6ae
Patch Set 1 : add sk_tools::Expectation class, to hold image digest and ignoreFailure boolean #Patch Set 2 : make ImageDigest compute the bitmap hash lazily #Patch Set 3 : properly handle ignoreFailure using sk_tools::Expectation class, with unittest to exercise #
Messages
Total messages: 5 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||
