tools/render_pictures_main.cpp - Issue 493363002: create sk_tools::Expectation class, similar to skiagm::Expectations class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/render_pictures_main.cpp

Issue 493363002: create sk_tools::Expectation class, similar to skiagm::Expectations class (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: properly handle ignoreFailure using sk_tools::Expectation class, with unittest to exercise Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/render_pictures_main.cpp

diff --git a/tools/render_pictures_main.cpp b/tools/render_pictures_main.cpp

index e62c3bce77c4412810ae1ee60c87cbfa37cf5077..595a78ee8cba820031687c67fbad977c6145f2a1 100644

--- a/tools/render_pictures_main.cpp

+++ b/tools/render_pictures_main.cpp

@@ -366,7 +366,7 @@ static bool render_picture(const SkString& inputPath, const SkString* writePath,

sk_tools::ImageDigest imageDigest(*bitmap);

jsonSummaryPtr->add(inputFilename.c_str(), outputFilename.c_str(), imageDigest);

if ((NULL != mismatchPath) && !mismatchPath->isEmpty() &&

- !jsonSummaryPtr->matchesExpectation(inputFilename.c_str(), imageDigest)) {

+ !jsonSummaryPtr->getExpectation(inputFilename.c_str()).matches(imageDigest)) {

success &= sk_tools::write_bitmap_to_disk(*bitmap, *mismatchPath, NULL,

outputFilename);

}

« no previous file with comments | « tools/image_expectations.cpp ('k') | tools/tests/render_pictures_test.py » ('j') | no next file with comments »