Issue 493303002: Make message center always scroll up upon notification removal

Issue 493303002: Make message center always scroll up upon notification removal (Closed)

Created:
6 years, 4 months ago by juyik

Modified:
6 years, 3 months ago

Reviewers:
Alexei Svitkine (slow), dewittj

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make message center always scroll up upon notification removal. Add a switch to enable it. This feature would fix the problem when a large notification moves downwards, it is partially obstructed. asvitkine: Please review histograms.xml BUG= Committed: https://crrev.com/a7be519752f930df9510761bb578204ed79fc20c Cr-Commit-Position: refs/heads/master@{#292017}

Patch Set 1 #

Patch Set 2 : Addresses Justin's comments. #

Patch Set 3 : Fixes gn build error. #

Patch Set 4 : Fixes android build issue. #

Patch Set 5 : . #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -1 line)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 2 3 4	2 chunks	+12 lines, -0 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/message_center/BUILD.gn	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/message_center/message_center.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	ui/message_center/message_center_switches.h	View		1 chunk	+18 lines, -0 lines	0 comments	Download
A	ui/message_center/message_center_switches.cc	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	ui/message_center/views/message_center_view.cc	View		3 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

dewittj

lgtm We will need a chrome://flags entry so that designers can try it out. Feel ...

6 years, 4 months ago (2014-08-22 16:43:00 UTC) #2

juyik

juyik@chromium.org changed reviewers: + asvitkine@chromium.org

6 years, 4 months ago (2014-08-25 18:55:39 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/juyik@chromium.org/493303002/80001

6 years, 3 months ago (2014-08-26 22:02:30 UTC) #7

commit-bot: I haz the power

Committed patchset #5 (80001) as 8f74d6582804cd1a5a12649ab6994a9346274265

6 years, 3 months ago (2014-08-26 23:01:34 UTC) #8

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:46:53 UTC) #9

Message was sent while issue was closed.

Patchset 5 (id:??) landed as
https://crrev.com/a7be519752f930df9510761bb578204ed79fc20c
Cr-Commit-Position: refs/heads/master@{#292017}

Expand Messages | Collapse Messages