Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 493303002: Make message center always scroll up upon notification removal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 28 matching lines...) Expand all
39 #include "ui/gfx/switches.h" 39 #include "ui/gfx/switches.h"
40 #include "ui/gl/gl_switches.h" 40 #include "ui/gl/gl_switches.h"
41 #include "ui/keyboard/keyboard_switches.h" 41 #include "ui/keyboard/keyboard_switches.h"
42 #include "ui/native_theme/native_theme_switches.h" 42 #include "ui/native_theme/native_theme_switches.h"
43 #include "ui/views/views_switches.h" 43 #include "ui/views/views_switches.h"
44 44
45 #if defined(OS_ANDROID) 45 #if defined(OS_ANDROID)
46 #include "chrome/common/chrome_version_info.h" 46 #include "chrome/common/chrome_version_info.h"
47 #include "components/data_reduction_proxy/common/data_reduction_proxy_switches.h " 47 #include "components/data_reduction_proxy/common/data_reduction_proxy_switches.h "
48 #include "components/omnibox/omnibox_switches.h" 48 #include "components/omnibox/omnibox_switches.h"
49 #else
50 #include "ui/message_center/message_center_switches.h"
49 #endif 51 #endif
50 52
51 #if defined(USE_ASH) 53 #if defined(USE_ASH)
52 #include "ash/ash_switches.h" 54 #include "ash/ash_switches.h"
53 #endif 55 #endif
54 56
55 #if defined(OS_CHROMEOS) 57 #if defined(OS_CHROMEOS)
56 #include "chromeos/chromeos_switches.h" 58 #include "chromeos/chromeos_switches.h"
57 #include "third_party/cros_system_api/switches/chrome_switches.h" 59 #include "third_party/cros_system_api/switches/chrome_switches.h"
58 #endif 60 #endif
(...skipping 1848 matching lines...) Expand 10 before | Expand all | Expand 10 after
1907 kOsWin | kOsLinux | kOsCrOS, 1909 kOsWin | kOsLinux | kOsCrOS,
1908 SINGLE_VALUE_TYPE(extensions::switches::kEnableExtensionActionRedesign) 1910 SINGLE_VALUE_TYPE(extensions::switches::kEnableExtensionActionRedesign)
1909 }, 1911 },
1910 { 1912 {
1911 "autofill-sync-credential", 1913 "autofill-sync-credential",
1912 IDS_FLAGS_AUTOFILL_SYNC_CREDENTIAL_NAME, 1914 IDS_FLAGS_AUTOFILL_SYNC_CREDENTIAL_NAME,
1913 IDS_FLAGS_AUTOFILL_SYNC_CREDENTIAL_DESCRIPTION, 1915 IDS_FLAGS_AUTOFILL_SYNC_CREDENTIAL_DESCRIPTION,
1914 kOsAll, 1916 kOsAll,
1915 MULTI_VALUE_TYPE(kAutofillSyncCredentialChoices) 1917 MULTI_VALUE_TYPE(kAutofillSyncCredentialChoices)
1916 }, 1918 },
1919 #if !defined(OS_ANDROID)
1920 {
1921 "enable-message-center-always-scroll-up-upon-notification-removal",
1922 IDS_FLAGS_ENABLE_MESSAGE_CENTER_ALWAYS_SCROLL_UP_UPON_REMOVAL_NAME,
1923 IDS_FLAGS_ENABLE_MESSAGE_CENTER_ALWAYS_SCROLL_UP_UPON_REMOVAL_DESCRIPTION,
1924 kOsDesktop,
1925 SINGLE_VALUE_TYPE(
1926 switches::kEnableMessageCenterAlwaysScrollUpUponNotificationRemoval)
1927 },
1928 #endif
1917 // NOTE: Adding new command-line switches requires adding corresponding 1929 // NOTE: Adding new command-line switches requires adding corresponding
1918 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 1930 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
1919 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 1931 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
1920 }; 1932 };
1921 1933
1922 const Experiment* experiments = kExperiments; 1934 const Experiment* experiments = kExperiments;
1923 size_t num_experiments = arraysize(kExperiments); 1935 size_t num_experiments = arraysize(kExperiments);
1924 1936
1925 // Stores and encapsulates the little state that about:flags has. 1937 // Stores and encapsulates the little state that about:flags has.
1926 class FlagsState { 1938 class FlagsState {
(...skipping 559 matching lines...) Expand 10 before | Expand all | Expand 10 after
2486 } 2498 }
2487 2499
2488 const Experiment* GetExperiments(size_t* count) { 2500 const Experiment* GetExperiments(size_t* count) {
2489 *count = num_experiments; 2501 *count = num_experiments;
2490 return experiments; 2502 return experiments;
2491 } 2503 }
2492 2504
2493 } // namespace testing 2505 } // namespace testing
2494 2506
2495 } // namespace about_flags 2507 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698