Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issue 493053004: [Android] Allow redundant |StartObservingRootWindow()| calls (Closed)

Created:
6 years, 4 months ago by jdduke (slow)
Modified:
6 years, 3 months ago
Reviewers:
no sievers
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, cjhopman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Allow redundant |StartObservingRootWindow()| calls Redundant requests to observe the window are harmless, and should be supported given the undefined relationship and timing between |RWHVAndroid::SetContentViewCore()| and |RWHVAndroid::WasShown()|, both of which can trigger observing of the root window. BUG=406651, 394604 NOTRY=true TBR=sievers@chromium.org Committed: https://crrev.com/789317e700bb3966398e4a0c5ec930bbcee9d0cf Cr-Commit-Position: refs/heads/master@{#291596}

Patch Set 1 #

Patch Set 2 : Make boliu@ happy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
jdduke (slow)
sievers@: Would you prefer an early return here? I don't think it hurts us to ...
6 years, 4 months ago (2014-08-23 01:13:44 UTC) #1
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 4 months ago (2014-08-23 01:19:30 UTC) #2
boliu
I think it should either support repeated calling by early out, or DCHECK and fix ...
6 years, 4 months ago (2014-08-23 01:24:50 UTC) #3
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 4 months ago (2014-08-23 01:45:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/493053004/20001
6 years, 4 months ago (2014-08-23 04:56:17 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (20001) as c1ca38978dc28791af4c7460fbe45c0ee9e49776
6 years, 3 months ago (2014-08-23 21:53:22 UTC) #6
no sievers
lgtm
6 years, 3 months ago (2014-08-25 17:11:18 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:31:38 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/789317e700bb3966398e4a0c5ec930bbcee9d0cf
Cr-Commit-Position: refs/heads/master@{#291596}

Powered by Google App Engine
This is Rietveld 408576698