content/browser/renderer_host/render_widget_host_view_android.cc - Issue 493053004: [Android] Allow redundant |StartObservingRootWindow()| calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 493053004: [Android] Allow redundant |StartObservingRootWindow()| calls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make boliu@ happy Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/render_widget_host_view_android.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc

index 7c8d13ddcd69ff05f9ba0a25649f7bd9007601fa..4c07536dc2dd1da63897cb63f687f0830b8c553e 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.cc

+++ b/content/browser/renderer_host/render_widget_host_view_android.cc

@@ -1264,7 +1264,9 @@ void RenderWidgetHostViewAndroid::RequestVSyncUpdate(uint32 requests) {

void RenderWidgetHostViewAndroid::StartObservingRootWindow() {

DCHECK(content_view_core_);

- DCHECK(!observing_root_window_);

+ if (observing_root_window_)

+ return;

observing_root_window_ = true;

content_view_core_->GetWindowAndroid()->AddObserver(this);

« no previous file with comments | « no previous file | no next file » | no next file with comments »