Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 49303002: [Ozone] Rename software implementation files to use Dri prefix (Closed)

Created:
7 years, 1 month ago by dnicoara
Modified:
7 years, 1 month ago
Reviewers:
rjkroege, sky
CC:
chromium-reviews, spang
Visibility:
Public.

Description

[Ozone] Rename software implementation files to use Dri Avoiding the DRM prefix such that it isn't confused with Digital Rights Management. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232930

Patch Set 1 #

Patch Set 2 : Removed ozone suffix #

Patch Set 3 : Remove ozone suffix #

Patch Set 4 : try 3 #

Patch Set 5 : try 4 #

Patch Set 6 : Rebased #

Patch Set 7 : fix ordering #

Patch Set 8 : Rebased #

Total comments: 1

Patch Set 9 : Fix ifdef #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -2708 lines) Patch
M ui/gfx/gfx.gyp View 1 2 3 4 5 1 chunk +12 lines, -12 lines 0 comments Download
A + ui/gfx/ozone/impl/dri_skbitmap.h View 1 2 3 4 5 6 7 8 3 chunks +13 lines, -13 lines 0 comments Download
A + ui/gfx/ozone/impl/dri_skbitmap.cc View 1 6 chunks +26 lines, -26 lines 0 comments Download
A + ui/gfx/ozone/impl/dri_surface.h View 1 5 chunks +20 lines, -20 lines 0 comments Download
A + ui/gfx/ozone/impl/dri_surface.cc View 1 5 chunks +13 lines, -13 lines 0 comments Download
A + ui/gfx/ozone/impl/dri_surface_factory.h View 1 2 3 4 5 6 3 chunks +17 lines, -17 lines 0 comments Download
A + ui/gfx/ozone/impl/dri_surface_factory.cc View 1 2 3 4 5 15 chunks +35 lines, -35 lines 0 comments Download
A + ui/gfx/ozone/impl/dri_surface_factory_unittest.cc View 1 12 chunks +52 lines, -52 lines 0 comments Download
A + ui/gfx/ozone/impl/dri_surface_unittest.cc View 1 6 chunks +36 lines, -36 lines 0 comments Download
A + ui/gfx/ozone/impl/dri_wrapper.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
A + ui/gfx/ozone/impl/dri_wrapper.cc View 1 6 chunks +11 lines, -11 lines 0 comments Download
ui/gfx/ozone/impl/drm_skbitmap_ozone.h View 1 chunk +0 lines, -56 lines 0 comments Download
ui/gfx/ozone/impl/drm_skbitmap_ozone.cc View 1 chunk +0 lines, -209 lines 0 comments Download
ui/gfx/ozone/impl/drm_wrapper_ozone.h View 1 chunk +0 lines, -85 lines 0 comments Download
ui/gfx/ozone/impl/drm_wrapper_ozone.cc View 1 chunk +0 lines, -93 lines 0 comments Download
A + ui/gfx/ozone/impl/file_surface_factory.h View 1 2 3 4 5 3 chunks +7 lines, -7 lines 0 comments Download
A + ui/gfx/ozone/impl/file_surface_factory.cc View 1 2 3 4 5 5 chunks +12 lines, -12 lines 0 comments Download
D ui/gfx/ozone/impl/file_surface_factory_ozone.h View 1 2 3 4 5 1 chunk +0 lines, -49 lines 0 comments Download
D ui/gfx/ozone/impl/file_surface_factory_ozone.cc View 1 2 3 4 5 1 chunk +0 lines, -96 lines 0 comments Download
A + ui/gfx/ozone/impl/hardware_display_controller.h View 1 6 chunks +14 lines, -14 lines 0 comments Download
A + ui/gfx/ozone/impl/hardware_display_controller.cc View 1 5 chunks +11 lines, -11 lines 0 comments Download
ui/gfx/ozone/impl/hardware_display_controller_ozone.h View 1 1 chunk +0 lines, -173 lines 0 comments Download
ui/gfx/ozone/impl/hardware_display_controller_ozone.cc View 1 1 chunk +0 lines, -118 lines 0 comments Download
ui/gfx/ozone/impl/hardware_display_controller_ozone_unittest.cc View 1 1 chunk +0 lines, -301 lines 0 comments Download
A + ui/gfx/ozone/impl/hardware_display_controller_unittest.cc View 1 4 chunks +58 lines, -58 lines 0 comments Download
D ui/gfx/ozone/impl/software_surface_factory_ozone.h View 1 2 3 4 5 1 chunk +0 lines, -76 lines 0 comments Download
D ui/gfx/ozone/impl/software_surface_factory_ozone.cc View 1 2 3 4 5 1 chunk +0 lines, -315 lines 0 comments Download
ui/gfx/ozone/impl/software_surface_factory_ozone_unittest.cc View 1 chunk +0 lines, -292 lines 0 comments Download
ui/gfx/ozone/impl/software_surface_ozone.h View 1 chunk +0 lines, -167 lines 0 comments Download
ui/gfx/ozone/impl/software_surface_ozone.cc View 1 chunk +0 lines, -113 lines 0 comments Download
ui/gfx/ozone/impl/software_surface_ozone_unittest.cc View 1 chunk +0 lines, -212 lines 0 comments Download
M ui/gfx/ozone/surface_factory_ozone.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/ozone_platform_dri.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/test/ozone_platform_test.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ui_unittests.gyp View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dnicoara
rjkroege@ please take a look at the renaming changes. Including sky@ for the gyp changes.
7 years, 1 month ago (2013-10-28 17:43:48 UTC) #1
rjkroege
Did you want to remove the unnecessary Ozone name parts for everything in ozone/impl given ...
7 years, 1 month ago (2013-10-29 16:48:59 UTC) #2
dnicoara
On 2013/10/29 16:48:59, rjkroege wrote: > Did you want to remove the unnecessary Ozone name ...
7 years, 1 month ago (2013-10-29 18:49:45 UTC) #3
rjkroege
lgtm with nit below https://codereview.chromium.org/49303002/diff/180001/ui/gfx/ozone/impl/dri_skbitmap.h File ui/gfx/ozone/impl/dri_skbitmap.h (right): https://codereview.chromium.org/49303002/diff/180001/ui/gfx/ozone/impl/dri_skbitmap.h#newcode5 ui/gfx/ozone/impl/dri_skbitmap.h:5: #ifndef UI_GFX__IMPL_DRI_SKBITMAP_H_ not right? over-eager ...
7 years, 1 month ago (2013-11-01 15:12:46 UTC) #4
dnicoara
On 2013/11/01 15:12:46, rjkroege wrote: > lgtm with nit below > > https://codereview.chromium.org/49303002/diff/180001/ui/gfx/ozone/impl/dri_skbitmap.h > File ...
7 years, 1 month ago (2013-11-01 15:17:28 UTC) #5
dnicoara
sky@ please take a look. Needs owner's approval for GYP changes.
7 years, 1 month ago (2013-11-04 21:04:45 UTC) #6
sky
gyp files are *, so you shouldn't need me to land this.
7 years, 1 month ago (2013-11-04 21:41:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/49303002/210001
7 years, 1 month ago (2013-11-04 21:50:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/49303002/210001
7 years, 1 month ago (2013-11-05 03:05:41 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 06:47:39 UTC) #10
Message was sent while issue was closed. 
Change committed as 232930

Powered by Google App Engine
This is Rietveld 408576698