mojo: Plumb through sufficient context to make real blink::WebInputEvents.

mojo: Plumb through sufficient context to make real blink::WebInputEvents.

This adds members to mojo::Event that are needed to construct
a blink::WebInputEvent, as well as the boilerplate to carry
those members on a ui::KeyEvent object, because the events
aren't sent directly from the native event source to html
viewer, but pass through multiple systems.

BUG=403514
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291301

[sky, 2014-08-21 15:44:42]

https://codereview.chromium.org/492863002/diff/160001/ui/events/event.cc
File ui/events/event.cc (right):

https://codereview.chromium.org/492863002/diff/160001/ui/events/event.cc#newc...
ui/events/event.cc:598: extended_mojo_data_() {
nit: remove as not needed (from all of these).

https://codereview.chromium.org/492863002/diff/160001/ui/events/event.cc#newc...
ui/events/event.cc:649: if (rhs.extended_mojo_data_) {
Why the setter and not just copy rhs.extended_mojo_data (same question for all
of these).

https://codereview.chromium.org/492863002/diff/160001/ui/events/event.cc#newc...
ui/events/event.cc:686: 
You don't set native_key_code

https://codereview.chromium.org/492863002/diff/160001/ui/events/event.cc#newc...
ui/events/event.cc:693: else if (extended_mojo_data_)
nit: no else after a return (for all of these).

https://codereview.chromium.org/492863002/diff/160001/ui/events/event.h
File ui/events/event.h (right):

https://codereview.chromium.org/492863002/diff/160001/ui/events/event.h#newco...
ui/events/event.h:613: void SetSelfContainedKeyEventData(int32_t
windows_key_code,
SelfContained? Maybe SetExtendedData? (KeyEvent is unnecessary since this
function is in the KeyEvent class).

It seems like this data is only used by mojo. If that's the case could we make
KeyEvent have a Data object that is a struct with a pure virtual destructor and
mojo has the code to set and manipulate it?

https://codereview.chromium.org/492863002/diff/160001/ui/events/event_utils.h
File ui/events/event_utils.h (right):

https://codereview.chromium.org/492863002/diff/160001/ui/events/event_utils.h...
ui/events/event_utils.h:107: EVENTS_EXPORT uint16 GetBlinkControlCharacter(int
windows_key_code,
As this code doesn't depend on blink it is weird to have this function here. Is
there some where better it can live? Some where that both events and blink
depend on?

[Elliot Glaysher, 2014-08-21 21:27:07]

ptal

[sky, 2014-08-21 21:47:32]

Nice, LGTM

https://codereview.chromium.org/492863002/diff/200001/mojo/services/public/cp...
File mojo/services/public/cpp/input_events/lib/input_events_type_converters.cc
(right):

https://codereview.chromium.org/492863002/diff/200001/mojo/services/public/cp...
mojo/services/public/cpp/input_events/lib/input_events_type_converters.cc:110:
virtual ExtendedKeyEventData* Clone() const OVERRIDE {
Prefix with // ui::ExtendedKeyEventData:
or whatever you prefer.

https://codereview.chromium.org/492863002/diff/200001/mojo/services/public/cp...
mojo/services/public/cpp/input_events/lib/input_events_type_converters.cc:117:
int32_t windows_key_code_;
const on these?

https://codereview.chromium.org/492863002/diff/200001/mojo/services/public/cp...
mojo/services/public/cpp/input_events/lib/input_events_type_converters.cc:120:
};
private: DISALLOW...

[Elliot Glaysher, 2014-08-21 22:07:58]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2014-08-21 22:12:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/erg@chromium.org/492863002/220001

[commit-bot: I haz the power, 2014-08-21 23:21:10]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[commit-bot: I haz the power, 2014-08-21 23:29:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-21 23:29:03]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[Elliot Glaysher, 2014-08-22 00:27:44]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2014-08-22 00:31:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/erg@chromium.org/492863002/220001

[commit-bot: I haz the power, 2014-08-22 01:33:59]

Committed patchset #12 (220001) as 291301