Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: chrome/browser/bookmarks/bookmark_stats.cc

Issue 49283004: Add UMA stats for tracking bookmark depth (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sky Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_stats.cc
diff --git a/chrome/browser/bookmarks/bookmark_stats.cc b/chrome/browser/bookmarks/bookmark_stats.cc
index 5d4d3dac8efffb3ef5e605ace47019fd39b0f78a..1ac8bd3178b33eb184df87acd35f314d685cbc7d 100644
--- a/chrome/browser/bookmarks/bookmark_stats.cc
+++ b/chrome/browser/bookmarks/bookmark_stats.cc
@@ -5,17 +5,31 @@
#include "chrome/browser/bookmarks/bookmark_stats.h"
#include "base/metrics/histogram.h"
+#include "chrome/browser/bookmarks/bookmark_model.h"
#include "content/public/browser/user_metrics.h"
-void RecordBookmarkLaunch(BookmarkLaunchLocation location) {
+void RecordBookmarkLaunch(const BookmarkNode* node,
+ BookmarkLaunchLocation location) {
if (location == BOOKMARK_LAUNCH_LOCATION_DETACHED_BAR ||
location == BOOKMARK_LAUNCH_LOCATION_ATTACHED_BAR) {
content::RecordAction(
content::UserMetricsAction("ClickedBookmarkBarURLButton"));
}
-
UMA_HISTOGRAM_ENUMERATION(
"Bookmarks.LaunchLocation", location, BOOKMARK_LAUNCH_LOCATION_LIMIT);
+
+ if (!node)
+ return;
+
+ // In the cases where a bookmark node is provided, record the depth of the
+ // bookmark in the tree.
+ int depth = 0;
+ for (const BookmarkNode* iter = node; iter != NULL; iter = iter->parent()) {
+ depth++;
+ }
+ // Record |depth - 2| to offset the invisible root node and permanent nodes
+ // (Bookmark Bar, Mobile Bookmarks or Other Bookmarks)
+ UMA_HISTOGRAM_COUNTS("Bookmarks.LaunchDepth", depth - 2);
}
void RecordBookmarkFolderOpen(BookmarkLaunchLocation location) {

Powered by Google App Engine
This is Rietveld 408576698