Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: chrome/browser/bookmarks/bookmark_stats.cc

Issue 49283004: Add UMA stats for tracking bookmark depth (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sky Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/bookmarks/bookmark_stats.h" 5 #include "chrome/browser/bookmarks/bookmark_stats.h"
6 6
7 #include "base/metrics/histogram.h" 7 #include "base/metrics/histogram.h"
8 #include "chrome/browser/bookmarks/bookmark_model.h"
8 #include "content/public/browser/user_metrics.h" 9 #include "content/public/browser/user_metrics.h"
9 10
10 void RecordBookmarkLaunch(BookmarkLaunchLocation location) { 11 void RecordBookmarkLaunch(const BookmarkNode* node,
12 BookmarkLaunchLocation location) {
11 if (location == BOOKMARK_LAUNCH_LOCATION_DETACHED_BAR || 13 if (location == BOOKMARK_LAUNCH_LOCATION_DETACHED_BAR ||
12 location == BOOKMARK_LAUNCH_LOCATION_ATTACHED_BAR) { 14 location == BOOKMARK_LAUNCH_LOCATION_ATTACHED_BAR) {
13 content::RecordAction( 15 content::RecordAction(
14 content::UserMetricsAction("ClickedBookmarkBarURLButton")); 16 content::UserMetricsAction("ClickedBookmarkBarURLButton"));
15 } 17 }
16
17 UMA_HISTOGRAM_ENUMERATION( 18 UMA_HISTOGRAM_ENUMERATION(
18 "Bookmarks.LaunchLocation", location, BOOKMARK_LAUNCH_LOCATION_LIMIT); 19 "Bookmarks.LaunchLocation", location, BOOKMARK_LAUNCH_LOCATION_LIMIT);
20
21 if (!node)
22 return;
23
24 // In the cases where a bookmark node is provided, record the depth of the
25 // bookmark in the tree.
26 int depth = 0;
27 for (const BookmarkNode* iter = node; iter != NULL; iter = iter->parent()) {
28 depth++;
29 }
30 // Record |depth - 2| to offset the invisible root node and permanent nodes
31 // (Bookmark Bar, Mobile Bookmarks or Other Bookmarks)
32 UMA_HISTOGRAM_COUNTS("Bookmarks.LaunchDepth", depth - 2);
19 } 33 }
20 34
21 void RecordBookmarkFolderOpen(BookmarkLaunchLocation location) { 35 void RecordBookmarkFolderOpen(BookmarkLaunchLocation location) {
22 if (location == BOOKMARK_LAUNCH_LOCATION_DETACHED_BAR || 36 if (location == BOOKMARK_LAUNCH_LOCATION_DETACHED_BAR ||
23 location == BOOKMARK_LAUNCH_LOCATION_ATTACHED_BAR) { 37 location == BOOKMARK_LAUNCH_LOCATION_ATTACHED_BAR) {
24 content::RecordAction( 38 content::RecordAction(
25 content::UserMetricsAction("ClickedBookmarkBarFolder")); 39 content::UserMetricsAction("ClickedBookmarkBarFolder"));
26 } 40 }
27 } 41 }
28 42
29 void RecordBookmarkAppsPageOpen(BookmarkLaunchLocation location) { 43 void RecordBookmarkAppsPageOpen(BookmarkLaunchLocation location) {
30 if (location == BOOKMARK_LAUNCH_LOCATION_DETACHED_BAR || 44 if (location == BOOKMARK_LAUNCH_LOCATION_DETACHED_BAR ||
31 location == BOOKMARK_LAUNCH_LOCATION_ATTACHED_BAR) { 45 location == BOOKMARK_LAUNCH_LOCATION_ATTACHED_BAR) {
32 content::RecordAction( 46 content::RecordAction(
33 content::UserMetricsAction("ClickedBookmarkBarAppsShortcutButton")); 47 content::UserMetricsAction("ClickedBookmarkBarAppsShortcutButton"));
34 } 48 }
35 } 49 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698