Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 492813002: Use a qualified path for grit/content_resources.h. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, qsr+mojo_chromium.org, tzik, yzshen+watch_chromium.org, dgrogan, dmazzoni+watch_chromium.org, jdduke+watch_chromium.org, jsbell+serviceworker_chromium.org, aboxhall+watch_chromium.org, ben+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, dtseng+watch_chromium.org, extensions-reviews_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, nhiroki, piman+watch_chromium.org, jsbell+idb_chromium.org, michaeln, plundblad+watch_chromium.org, serviceworker-reviews, Aaron Boodman, kinuko+serviceworker, cmumford, horo+watch_chromium.org, darin (slow to review)
Project:
chromium
Visibility:
Public.

Description

Use a qualified path for grit/content_resources.h. The source file changes were done using: for f in $(git grep -l '"grit/content_resources.h"' -- '*.cc' '*.mm'); do sed -i -e 's/"grit\/content_resources.h"/"content\/grit\/content_resources.h"/' $f ; done tools/git/for-all-touched-files.py -c "tools/sort-headers.py -f [[FILENAME]]" The gyp, gn, and DEPS changes were lovingly hand-crafted. BUG=401588 R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290896

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M content/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/DEPS View 2 chunks +1 line, -1 line 0 comments Download
M content/app/resources/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/accessibility_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_internals_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_internals_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/media/media_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/webrtc_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_emulator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_internals_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui_data_source_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui_mojo_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/common/sandbox_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/content_resources.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/test/webui_resource_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/dispatcher.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
6 years, 4 months ago (2014-08-20 15:52:19 UTC) #1
Lei Zhang
lgtm
6 years, 4 months ago (2014-08-20 19:14:43 UTC) #2
Nico
6 years, 4 months ago (2014-08-20 19:42:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 290896.

Powered by Google App Engine
This is Rietveld 408576698