Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 492773002: Removed the redundant 'OS=win' condition (Closed)

Created:
6 years, 4 months ago by ARUNKK
Modified:
6 years, 3 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removed the redundant 'OS=win' condition check in common.gypi. Committed: https://crrev.com/9af92a16534e9b8e3b4056b40fc23fbcbbc5441d Cr-Commit-Position: refs/heads/master@{#295748}

Patch Set 1 #

Patch Set 2 : Removed entry from AUTHORs list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M build/common.gypi View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (3 generated)
ARUNKK
PTAL
6 years, 4 months ago (2014-08-22 07:30:05 UTC) #1
ARUNKK
The CQ bit was checked by kulkarni.a@samsung.com
6 years, 4 months ago (2014-08-26 05:12:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kulkarni.a@samsung.com/492773002/1
6 years, 4 months ago (2014-08-26 05:13:37 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-26 05:13:38 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-26 05:13:39 UTC) #5
lgombos
l.gombos@samsung.com changed reviewers: + thakis@chromium.org - kphanee@chromium.org, siva.gunturi@samsung.com, sohan.jyoti@samsung.com, vivekg@chromium.org
6 years, 4 months ago (2014-08-26 05:26:37 UTC) #6
lgombos
Moving non-reviewers to CC and adding a thakis to review. PTAL.
6 years, 4 months ago (2014-08-26 05:26:37 UTC) #7
lgombos
l.gombos@samsung.com changed reviewers: - l.gombos@samsung.com
6 years, 4 months ago (2014-08-26 05:26:54 UTC) #8
lgombos
6 years, 4 months ago (2014-08-26 05:26:54 UTC) #9
Nico
I can't see "kulkarni.a" in the CLA signers list ( http://www.chromium.org/developers/contributing-code/external-contributor-checklist ). The patch mostly ...
6 years, 3 months ago (2014-08-26 20:29:33 UTC) #10
ARUNKK
On 2014/08/26 20:29:33, Nico (hiding) wrote: > I can't see "kulkarni.a" in the CLA signers ...
6 years, 3 months ago (2014-08-27 11:23:47 UTC) #11
ARUNKK
PTAL.
6 years, 3 months ago (2014-09-19 07:10:16 UTC) #14
brettw
lgtm
6 years, 3 months ago (2014-09-19 17:12:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/492773002/20001
6 years, 3 months ago (2014-09-19 17:47:31 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c61c35bc93ac1f6c3492aa3a49d7e82fa49b46ad
6 years, 3 months ago (2014-09-19 18:47:39 UTC) #18
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 18:48:29 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9af92a16534e9b8e3b4056b40fc23fbcbbc5441d
Cr-Commit-Position: refs/heads/master@{#295748}

Powered by Google App Engine
This is Rietveld 408576698