|
|
DescriptionRemoved the redundant 'OS=win' condition check in common.gypi.
Committed: https://crrev.com/9af92a16534e9b8e3b4056b40fc23fbcbbc5441d
Cr-Commit-Position: refs/heads/master@{#295748}
Patch Set 1 #Patch Set 2 : Removed entry from AUTHORs list #
Messages
Total messages: 19 (3 generated)
PTAL
The CQ bit was checked by kulkarni.a@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kulkarni.a@samsung.com/492773002/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Moving non-reviewers to CC and adding a thakis to review. PTAL.
l.gombos@samsung.com changed reviewers: - l.gombos@samsung.com
I can't see "kulkarni.a" in the CLA signers list ( http://www.chromium.org/developers/contributing-code/external-contributor-che... ). The patch mostly just moves code around, I'm not sure if this is worth muddying up blame output for?
On 2014/08/26 20:29:33, Nico (hiding) wrote: > I can't see "kulkarni.a" in the CLA signers list ( > http://www.chromium.org/developers/contributing-code/external-contributor-che... > ). > > The patch mostly just moves code around, I'm not sure if this is worth muddying > up blame output for? Hi , I have received the CLA for "kulkarni.a@samsung.com" .
kulkarni.a@samsung.com changed reviewers: + darin@chromium.org - thakis@chromium.org
kulkarni.a@samsung.com changed reviewers: + brettw@chromium.org
PTAL.
lgtm
The CQ bit was checked by kulkarni.a@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/492773002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as c61c35bc93ac1f6c3492aa3a49d7e82fa49b46ad
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9af92a16534e9b8e3b4056b40fc23fbcbbc5441d Cr-Commit-Position: refs/heads/master@{#295748} |