Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3312)

Unified Diff: build/common.gypi

Issue 492773002: Removed the redundant 'OS=win' condition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed entry from AUTHORs list Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 6f62a0f4610bcaf4059ab914be9f052f51886ad7..e981f28adde5c3307bf44db41ca622c05277ee9b 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3004,14 +3004,15 @@
'VCCLCompilerTool': { 'WarnAsError': 'false' },
}
}],
+ [ 'component=="shared_library"', {
+ # TODO(darin): Unfortunately, some third_party code depends on base.
+ 'msvs_disabled_warnings': [
+ 4251, # class 'std::xx' needs to have dll-interface.
+ ],
+ }],
],
}],
- # TODO(darin): Unfortunately, some third_party code depends on base.
- [ 'OS=="win" and component=="shared_library"', {
- 'msvs_disabled_warnings': [
- 4251, # class 'std::xx' needs to have dll-interface.
- ],
- }],
+
[ 'OS=="mac" or OS=="ios"', {
'xcode_settings': {
'WARNING_CFLAGS!': ['-Wall', '-Wextra'],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698