Lookup glyphs based on character code and language tag.

Lookup glyphs based on character code and language tag.

This is particularly important on Android where we expect the
FontManager to return different glyphs for the same character code
depending on language.

BUG=skia:2829
Committed: https://skia.googlesource.com/skia/+/0d393a92ca6c1a328e4fa0c4b311916789659de5

[tomhudson, 2014-08-21 20:24:41]

lgtm

https://codereview.chromium.org/492763003/diff/1/gm/fontmgr.cpp
File gm/fontmgr.cpp (right):

https://codereview.chromium.org/492763003/diff/1/gm/fontmgr.cpp#newcode36
gm/fontmgr.cpp:36: x = drawString(canvas, ch, x, y, paint) + 20;
Assuming character width << 20?

[bungeman-skia, 2014-08-21 21:53:46]

lgtm

[tomhudson, 2014-08-22 11:40:01]

The CQ bit was checked by tomhudson@google.com

[commit-bot: I haz the power, 2014-08-22 11:40:12]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/djsollen@google.com/492763003/1

[commit-bot: I haz the power, 2014-08-22 11:46:25]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on tryserver.skia
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug...)
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on tryserver.skia
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Relea...)

[commit-bot: I haz the power, 2014-08-22 11:49:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 11:49:03]

Try jobs failed on following builders:
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on tryserver.skia
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Relea...)

[bungeman-skia, 2014-08-22 13:41:09]

On 2014/08/22 11:49:03, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on tryserver.skia
>
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Relea...)

Oh, yeah, forgot to mention that this won't work on Linux at the moment. I've
got a CL for that...

[djsollen, 2014-08-26 15:33:10]

The CQ bit was checked by djsollen@google.com

[commit-bot: I haz the power, 2014-08-26 15:33:41]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/djsollen@google.com/492763003/1

[commit-bot: I haz the power, 2014-08-26 15:39:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on tryserver.skia
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug...)
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on tryserver.skia
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Relea...)

[commit-bot: I haz the power, 2014-08-26 15:42:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-26 15:42:22]

Try jobs failed on following builders:
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on tryserver.skia
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Relea...)

[djsollen, 2014-08-26 15:44:22]

ben, this looks to be failing in your new fontconfig impl.

[bungeman-skia, 2014-08-26 21:15:44]

https://codereview.chromium.org/492763003/diff/1/gm/fontmgr.cpp
File gm/fontmgr.cpp (right):

https://codereview.chromium.org/492763003/diff/1/gm/fontmgr.cpp#newcode42
gm/fontmgr.cpp:42: typeface->getFamilyName(&familyName);
'typeface' can be NULL here if 'matchFamilyStyleCharacter' returns NULL, which
it will if there is no typeface with the given character (or if it isn't yet
implemented). I think that if 'matchFamilyStyleCharacter' returns NULL above, we
might just want to draw nothing (just return at that point). This will also move
any rebaselining effort to whoever actually implements
'matchFamilyStyleCharacter' on other platforms.

[bungeman-skia, 2014-08-26 21:55:36]

https://codereview.chromium.org/492763003/diff/1/gm/fontmgr.cpp
File gm/fontmgr.cpp (right):

https://codereview.chromium.org/492763003/diff/1/gm/fontmgr.cpp#newcode43
gm/fontmgr.cpp:43: SkTypeface* typefaceCopy =
fm->legacyCreateTypeface(familyName.c_str(), SkTypeface::kNormal);
Instead of 'SkTypeface::kNormal', you might want to use 'typeface->style()'.

[djsollen, 2014-08-27 13:56:08]

The CQ bit was checked by djsollen@google.com

[commit-bot: I haz the power, 2014-08-27 13:56:42]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/djsollen@google.com/492763003/20001

[commit-bot: I haz the power, 2014-08-27 14:03:20]

Committed patchset #2 (20001) as 0d393a92ca6c1a328e4fa0c4b311916789659de5