Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 492503004: Fix BrowserActionContainer chevron visibility regression (Closed)

Created:
6 years, 4 months ago by Devlin
Modified:
6 years, 3 months ago
Reviewers:
Finnur, Peter Kasting
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix BrowserActionContainer chevron visibility regression https://codereview.chromium.org/476873002 introduced a regression where shrinking the size of the extensions toolbar to 0 would not show the chevron anymore. Fix the regression, and add a test so it doesn't happen again. BUG=407134 Committed: https://crrev.com/cf57e8b1ea2b1f75d1ac3d74c52a85f4951c590e Cr-Commit-Position: refs/heads/master@{#291754}

Patch Set 1 #

Patch Set 2 : Cleaner ternary, per Finnur's suggestion #

Total comments: 2

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Devlin
6 years, 4 months ago (2014-08-25 16:07:43 UTC) #1
Finnur
LGTM
6 years, 4 months ago (2014-08-25 16:43:25 UTC) #2
Devlin
rdevlin.cronin@chromium.org changed reviewers: + pkasting@chromium.org
6 years, 4 months ago (2014-08-25 19:30:32 UTC) #3
Devlin
6 years, 4 months ago (2014-08-25 19:30:32 UTC) #4
Devlin
On 2014/08/25 19:30:32, Devlin wrote: (+pkasting@ for OWNERS)
6 years, 4 months ago (2014-08-25 19:33:27 UTC) #5
Peter Kasting
LGTM https://codereview.chromium.org/492503004/diff/20001/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc File chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc (right): https://codereview.chromium.org/492503004/diff/20001/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc#newcode231 chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc:231: EXPECT_NE(container->GetPreferredSize(), gfx::Size()); Nit: (expected, actual) Or you could ...
6 years, 4 months ago (2014-08-25 19:33:47 UTC) #6
Devlin
https://codereview.chromium.org/492503004/diff/20001/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc File chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc (right): https://codereview.chromium.org/492503004/diff/20001/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc#newcode231 chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc:231: EXPECT_NE(container->GetPreferredSize(), gfx::Size()); On 2014/08/25 19:33:47, Peter Kasting wrote: > ...
6 years, 4 months ago (2014-08-25 19:45:51 UTC) #7
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 4 months ago (2014-08-25 19:45:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/492503004/40001
6 years, 4 months ago (2014-08-25 19:46:53 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (40001) as 184ad2d518c55fa4a8a7ada942c63bc78cdb1917
6 years, 4 months ago (2014-08-25 20:40:53 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:37:19 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cf57e8b1ea2b1f75d1ac3d74c52a85f4951c590e
Cr-Commit-Position: refs/heads/master@{#291754}

Powered by Google App Engine
This is Rietveld 408576698