Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2969)

Unified Diff: chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc

Issue 492503004: Fix BrowserActionContainer chevron visibility regression (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/toolbar/browser_actions_container.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
diff --git a/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc b/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
index bc94ac0e782344f6465bf6162c886f458041809d..0b2abb8bf6109517468d9802e8242e843ae3bd20 100644
--- a/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
+++ b/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
@@ -217,6 +217,18 @@ IN_PROC_BROWSER_TEST_F(BrowserActionsContainerTest, Visibility) {
EXPECT_EQ(3, browser_actions_bar()->NumberOfBrowserActions());
EXPECT_EQ(3, browser_actions_bar()->VisibleBrowserActions());
EXPECT_EQ(idA, browser_actions_bar()->GetExtensionId(0));
+
+ // Shrink the browser actions bar to zero visible icons.
+ // No icons should be visible, but we *should* show the chevron and have a
+ // non-empty size.
+ browser_actions_bar()->SetIconVisibilityCount(0);
+ EXPECT_EQ(0, browser_actions_bar()->VisibleBrowserActions());
+ BrowserActionsContainer* container =
+ BrowserView::GetBrowserViewForBrowser(browser())
+ ->toolbar()->browser_actions();
+ ASSERT_TRUE(container->chevron());
+ EXPECT_TRUE(container->chevron()->visible());
+ EXPECT_FALSE(container->GetPreferredSize().IsEmpty());
}
IN_PROC_BROWSER_TEST_F(BrowserActionsContainerTest, ForceHide) {
« no previous file with comments | « chrome/browser/ui/views/toolbar/browser_actions_container.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698