downloads: Make header look more like settings, extensions, history, and

downloads: Make header look more like settings, extensions, history, and
bookmarks.

R=benjhayden@chromium.org
BUG=405717
TEST=visual

Committed: https://crrev.com/07be9b39f440a4b9add82ab2e7d1226c68c1113d
Cr-Commit-Position: refs/heads/master@{#291593}

[Dan Beam, 2014-08-22 00:06:28]

http://imgur.com/a/3QJ3P

[benjhayden, 2014-08-22 16:54:01]

Thanks for the screenshots! Very helpful.

I haven't worked on chrome://downloads in a while. Want to take ownership? :-)

https://codereview.chromium.org/492163004/diff/1/chrome/browser/resources/dow...
File chrome/browser/resources/downloads/downloads.css (left):

https://codereview.chromium.org/492163004/diff/1/chrome/browser/resources/dow...
chrome/browser/resources/downloads/downloads.css:19: html[dir='rtl'] .form {
Yay, no more floats!
Sorry, I'm not very familiar with how flex handles rtl. Can you take a before
and after in an RTL language?

https://codereview.chromium.org/492163004/diff/1/chrome/browser/resources/dow...
File chrome/browser/resources/downloads/downloads.css (right):

https://codereview.chromium.org/492163004/diff/1/chrome/browser/resources/dow...
chrome/browser/resources/downloads/downloads.css:8: margin: 0 12px;
I know most of these magic numbers were here before you (and me), but can you
tell how hard it would be to share them with the bookmarks page, if only for a
TODO?

[Dan Beam, 2014-08-22 23:33:47]

https://codereview.chromium.org/492163004/diff/1/chrome/browser/resources/dow...
File chrome/browser/resources/downloads/downloads.css (left):

https://codereview.chromium.org/492163004/diff/1/chrome/browser/resources/dow...
chrome/browser/resources/downloads/downloads.css:19: html[dir='rtl'] .form {
On 2014/08/22 16:54:01, benjhayden_chromium wrote:
> Yay, no more floats!
> Sorry, I'm not very familiar with how flex handles rtl. Can you take a before
> and after in an RTL language?

http://imgur.com/a/89oEk

https://codereview.chromium.org/492163004/diff/1/chrome/browser/resources/dow...
File chrome/browser/resources/downloads/downloads.css (right):

https://codereview.chromium.org/492163004/diff/1/chrome/browser/resources/dow...
chrome/browser/resources/downloads/downloads.css:8: margin: 0 12px;
On 2014/08/22 16:54:01, benjhayden_chromium wrote:
> I know most of these magic numbers were here before you (and me), but can you
> tell how hard it would be to share them with the bookmarks page, if only for a
> TODO?

https://codereview.chromium.org/502613003

[benjhayden, 2014-08-22 23:40:08]

lgtm

[Dan Beam, 2014-08-23 00:00:43]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-08-23 00:02:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dbeam@chromium.org/492163004/1

[commit-bot: I haz the power, 2014-08-23 21:45:16]

Committed patchset #1 (1) as 8dc1e6eaedf3ca0e0c406aba69b08568c072e706

[commit-bot: I haz the power, 2014-09-10 02:31:30]

Patchset 1 (id:??) landed as
https://crrev.com/07be9b39f440a4b9add82ab2e7d1226c68c1113d
Cr-Commit-Position: refs/heads/master@{#291593}