downloads/bookmarks: combine header CSS between downloads and bookmarks.

downloads/bookmarks: combine header CSS between downloads and bookmarks.

R=benjhayden@chromium.org
BUG=405717
Committed: https://crrev.com/f8b3fe9660d8dda318800f55d5e29799bbfd43f7
Cr-Commit-Position: refs/heads/master@{#291738}

[Dan Beam, 2014-08-22 23:34:14]

based on: https://codereview.chromium.org/492163004/

[benjhayden, 2014-08-22 23:50:10]

https://codereview.chromium.org/502613003/diff/40001/chrome/browser/resources...
File chrome/browser/resources/bookmark_manager/css/bmm.css (left):

https://codereview.chromium.org/502613003/diff/40001/chrome/browser/resources...
chrome/browser/resources/bookmark_manager/css/bmm.css:317: white-space: nowrap;
Why not share both nowrap and flex in search_header.css?

[Dan Beam, 2014-08-25 15:54:15]

https://codereview.chromium.org/502613003/diff/40001/chrome/browser/resources...
File chrome/browser/resources/bookmark_manager/css/bmm.css (left):

https://codereview.chromium.org/502613003/diff/40001/chrome/browser/resources...
chrome/browser/resources/bookmark_manager/css/bmm.css:317: white-space: nowrap;
On 2014/08/22 23:50:10, benjhayden_chromium wrote:
> Why not share both nowrap and flex in search_header.css?

.summary {
  white-space: nowrap;
}

only applies to bookmarks and

.summary {
  display: flex;
}

.summary > * {
  flex: {1, none};
}

only applies to downloads.

[benjhayden, 2014-08-25 16:11:30]

On 2014/08/25 15:54:15, Dan Beam wrote:
>
https://codereview.chromium.org/502613003/diff/40001/chrome/browser/resources...
> File chrome/browser/resources/bookmark_manager/css/bmm.css (left):
> 
>
https://codereview.chromium.org/502613003/diff/40001/chrome/browser/resources...
> chrome/browser/resources/bookmark_manager/css/bmm.css:317: white-space:
nowrap;
> On 2014/08/22 23:50:10, benjhayden_chromium wrote:
> > Why not share both nowrap and flex in search_header.css?
> 
> .summary {
>   white-space: nowrap;
> }
> 
> only applies to bookmarks and
> 
> .summary {
>   display: flex;
> }
> 
> .summary > * {
>   flex: {1, none};
> }
> 
> only applies to downloads.

I'm sorry, I was asking the deeper question: why should that be so? Why should
the downloads summary wrap when bookmarks should not? Why should downloads flex
when bookmarks should not? Keeping any incongruity between them seems
incongruous with unifying them.
It's a minor point that you can ignore if you want, so LGTM, but I just thought
I'd ask.

[Dan Beam, 2014-08-25 17:58:27]

On 2014/08/25 16:11:30, benjhayden_chromium wrote:
> On 2014/08/25 15:54:15, Dan Beam wrote:
> >
>
https://codereview.chromium.org/502613003/diff/40001/chrome/browser/resources...
> > File chrome/browser/resources/bookmark_manager/css/bmm.css (left):
> > 
> >
>
https://codereview.chromium.org/502613003/diff/40001/chrome/browser/resources...
> > chrome/browser/resources/bookmark_manager/css/bmm.css:317: white-space:
> nowrap;
> > On 2014/08/22 23:50:10, benjhayden_chromium wrote:
> > > Why not share both nowrap and flex in search_header.css?
> > 
> > .summary {
> >   white-space: nowrap;
> > }
> > 
> > only applies to bookmarks and
> > 
> > .summary {
> >   display: flex;
> > }
> > 
> > .summary > * {
> >   flex: {1, none};
> > }
> > 
> > only applies to downloads.
> 
> I'm sorry, I was asking the deeper question: why should that be so? Why should
> the downloads summary wrap when bookmarks should not? Why should downloads
flex
> when bookmarks should not? Keeping any incongruity between them seems
> incongruous with unifying them.
> It's a minor point that you can ignore if you want, so LGTM, but I just
thought
> I'd ask.

Done.

[benjhayden, 2014-08-25 18:14:25]

LGTM Thanks!

[Dan Beam, 2014-08-25 18:20:03]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-08-25 18:20:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dbeam@chromium.org/502613003/80001

[commit-bot: I haz the power, 2014-08-25 19:21:40]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)

[commit-bot: I haz the power, 2014-08-25 19:27:54]

Committed patchset #3 (80001) as aae6fa5aa86412fd02a0deded82f786ebafafa17

[commit-bot: I haz the power, 2014-09-10 02:36:45]

Patchset 3 (id:??) landed as
https://crrev.com/f8b3fe9660d8dda318800f55d5e29799bbfd43f7
Cr-Commit-Position: refs/heads/master@{#291738}