chrome/browser/ui/app_list/app_list_service_impl.h - Issue 492163002: Fix Profile* lifetime issues in Chrome's AppListViewDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/app_list_service_impl.h

Issue 492163002: Fix Profile* lifetime issues in Chrome's AppListViewDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: update unit test, cl format Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/app_list/app_list_service_impl.h

diff --git a/chrome/browser/ui/app_list/app_list_service_impl.h b/chrome/browser/ui/app_list/app_list_service_impl.h

index 6fe68aec17630916bfde82251a5120c1da7f5b56..4102ee3edf2fcaae8c34e1b855c30a5d7b6c9e37 100644

--- a/chrome/browser/ui/app_list/app_list_service_impl.h

+++ b/chrome/browser/ui/app_list/app_list_service_impl.h

@@ -53,6 +53,10 @@ class AppListServiceImpl : public AppListService,

protected:

AppListServiceImpl();

+ // Destroy the app list. Called when the profile that the app list is showing

+ // is being deleted.

+ virtual void DestroyAppList() = 0;

void InvalidatePendingProfileLoads();

ProfileLoader& profile_loader() { return *profile_loader_; }

const ProfileLoader& profile_loader() const { return *profile_loader_; }