Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: chrome/browser/ui/app_list/app_list_service_impl.h

Issue 492163002: Fix Profile* lifetime issues in Chrome's AppListViewDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update unit test, cl format Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_IMPL_H_ 5 #ifndef CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_IMPL_H_
6 #define CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_IMPL_H_ 6 #define CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_IMPL_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 virtual void SetProfilePath(const base::FilePath& profile_path) OVERRIDE; 46 virtual void SetProfilePath(const base::FilePath& profile_path) OVERRIDE;
47 virtual void Show() OVERRIDE; 47 virtual void Show() OVERRIDE;
48 virtual void AutoShowForProfile(Profile* requested_profile) OVERRIDE; 48 virtual void AutoShowForProfile(Profile* requested_profile) OVERRIDE;
49 virtual void EnableAppList(Profile* initial_profile, 49 virtual void EnableAppList(Profile* initial_profile,
50 AppListEnableSource enable_source) OVERRIDE; 50 AppListEnableSource enable_source) OVERRIDE;
51 virtual void CreateShortcut() OVERRIDE; 51 virtual void CreateShortcut() OVERRIDE;
52 52
53 protected: 53 protected:
54 AppListServiceImpl(); 54 AppListServiceImpl();
55 55
56 // Destroy the app list. Called when the profile that the app list is showing
57 // is being deleted.
58 virtual void DestroyAppList() = 0;
59
56 void InvalidatePendingProfileLoads(); 60 void InvalidatePendingProfileLoads();
57 ProfileLoader& profile_loader() { return *profile_loader_; } 61 ProfileLoader& profile_loader() { return *profile_loader_; }
58 const ProfileLoader& profile_loader() const { return *profile_loader_; } 62 const ProfileLoader& profile_loader() const { return *profile_loader_; }
59 63
60 // Perform startup checks shared between desktop implementations of the app 64 // Perform startup checks shared between desktop implementations of the app
61 // list. Currently this checks command line flags to enable or disable the app 65 // list. Currently this checks command line flags to enable or disable the app
62 // list, and records UMA stats delayed from a previous Chrome process. 66 // list, and records UMA stats delayed from a previous Chrome process.
63 void PerformStartupChecks(Profile* initial_profile); 67 void PerformStartupChecks(Profile* initial_profile);
64 68
65 private: 69 private:
(...skipping 14 matching lines...) Expand all
80 scoped_ptr<ProfileStore> profile_store_; 84 scoped_ptr<ProfileStore> profile_store_;
81 base::WeakPtrFactory<AppListServiceImpl> weak_factory_; 85 base::WeakPtrFactory<AppListServiceImpl> weak_factory_;
82 base::CommandLine command_line_; 86 base::CommandLine command_line_;
83 PrefService* local_state_; 87 PrefService* local_state_;
84 scoped_ptr<ProfileLoader> profile_loader_; 88 scoped_ptr<ProfileLoader> profile_loader_;
85 89
86 DISALLOW_COPY_AND_ASSIGN(AppListServiceImpl); 90 DISALLOW_COPY_AND_ASSIGN(AppListServiceImpl);
87 }; 91 };
88 92
89 #endif // CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_IMPL_H_ 93 #endif // CHROME_BROWSER_UI_APP_LIST_APP_LIST_SERVICE_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698