Issue 491863002: Don't inline Array.shift() if receiver map is not extensible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 491863002: Don't inline Array.shift() if receiver map is not extensible. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer

Modified:
6 years, 4 months ago

Reviewers:
Jarin, Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Don't inline Array.shift() if receiver map is not extensible. TEST=mjsunit/regress/regress-crbug-405517 BUG=405517 LOG=y R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23255

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	src/hydrogen.cc	View		1 chunk	+1 line, -1 line	1 comment	Download
	A +	test/mjsunit/regress/regress-crbug-405517.js	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

https://codereview.chromium.org/491863002/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/491863002/diff/1/src/hydrogen.cc#newcode8337 src/hydrogen.cc:8337: if (!receiver_map->is_extensible()) return false; Please also change kArrayPush etc ...

6 years, 4 months ago (2014-08-20 13:39:43 UTC) #2

Benedikt Meurer

Cannot reproduce with push or pop, deopts properly.

6 years, 4 months ago (2014-08-21 04:44:06 UTC) #3

Benedikt Meurer

6 years, 4 months ago (2014-08-21 06:23:52 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as 23255 (presubmit successful).

Expand Messages | Collapse Messages