src/hydrogen.cc - Issue 491863002: Don't inline Array.shift() if receiver map is not extensible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 491863002: Don't inline Array.shift() if receiver map is not extensible. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 6096c248970e2e0b0f1950cd8ae238f1b62b7d99..99760361140f6c6d242b0cba2c220719ba98500e 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -8334,7 +8334,7 @@ bool HOptimizedGraphBuilder::TryInlineBuiltinMethodCall(

ElementsKind kind = receiver_map->elements_kind();

if (!IsFastElementsKind(kind)) return false;

if (receiver_map->is_observed()) return false;

- DCHECK(receiver_map->is_extensible());

+ if (!receiver_map->is_extensible()) return false;

Toon Verwaest 2014/08/20 13:39:43 Please also change kArrayPush etc if they are also

// If there may be elements accessors in the prototype chain, the fast

// inlined version can't be used.

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-405517.js » ('j') | no next file with comments »