Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 491703003: Fix call to setExtensionAndShowOverlay() (Closed)

Created:
6 years, 4 months ago by ericzeng
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase? #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/extensions/extension_list.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 32 (0 generated)
ericzeng
Sorry about that, PTAL
6 years, 4 months ago (2014-08-21 23:11:14 UTC) #1
not at google - send to devlin
lgtm, but no empty BUG=
6 years, 4 months ago (2014-08-21 23:12:04 UTC) #2
ericzeng
The CQ bit was checked by ericzeng@chromium.org
6 years, 4 months ago (2014-08-21 23:26:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericzeng@chromium.org/491703003/1
6 years, 4 months ago (2014-08-21 23:29:32 UTC) #4
Vitaly Pavlenko
lgtm
6 years, 4 months ago (2014-08-21 23:39:11 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 00:23:33 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 00:26:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/8279)
6 years, 4 months ago (2014-08-22 00:26:34 UTC) #8
ericzeng
The CQ bit was checked by ericzeng@chromium.org
6 years, 4 months ago (2014-08-22 00:44:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericzeng@chromium.org/491703003/20001
6 years, 4 months ago (2014-08-22 00:50:47 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 01:49:56 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 02:43:57 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/1203)
6 years, 4 months ago (2014-08-22 02:43:58 UTC) #13
ericzeng
The CQ bit was checked by ericzeng@chromium.org
6 years, 4 months ago (2014-08-22 03:48:27 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericzeng@chromium.org/491703003/20001
6 years, 4 months ago (2014-08-22 03:49:14 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 04:45:27 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 05:39:31 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/1280)
6 years, 4 months ago (2014-08-22 05:39:32 UTC) #18
ericzeng
The CQ bit was checked by ericzeng@chromium.org
6 years, 4 months ago (2014-08-22 18:06:27 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericzeng@chromium.org/491703003/40001
6 years, 4 months ago (2014-08-22 18:07:14 UTC) #20
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 19:04:20 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 19:06:51 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/8667)
6 years, 4 months ago (2014-08-22 19:06:52 UTC) #23
ericzeng
The CQ bit was checked by ericzeng@chromium.org
6 years, 4 months ago (2014-08-22 19:14:29 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericzeng@chromium.org/491703003/40001
6 years, 4 months ago (2014-08-22 19:15:33 UTC) #25
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 19:42:48 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 19:45:12 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/8692)
6 years, 4 months ago (2014-08-22 19:45:13 UTC) #28
ericzeng
The CQ bit was checked by ericzeng@chromium.org
6 years, 4 months ago (2014-08-22 19:50:20 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericzeng@chromium.org/491703003/40001
6 years, 4 months ago (2014-08-22 19:51:16 UTC) #30
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 19:54:13 UTC) #31
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 20:03:07 UTC) #32
Message was sent while issue was closed.
Committed patchset #3 (40001) as 291488

Powered by Google App Engine
This is Rietveld 408576698