chrome/browser/resources/extensions/extension_list.js - Issue 491703003: Fix call to setExtensionAndShowOverlay()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 491703003: Fix call to setExtensionAndShowOverlay() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/extensions/extension_list.js

diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js

index 08fb75e0ad1412d505af64b9625c3ff909b23254..d39599d9ac7528c3e08485deb3abc74eee0ec175 100644

--- a/chrome/browser/resources/extensions/extension_list.js

+++ b/chrome/browser/resources/extensions/extension_list.js

@@ -195,7 +195,7 @@ cr.define('options', function() {

options.addEventListener('click', function(e) {

if (this.data_.enableEmbeddedExtensionOptions) {

extensions.ExtensionOptionsOverlay.getInstance().

- setExtensionAndShowOverlay([extension.id], extension.name);

+ setExtensionAndShowOverlay(extension.id, extension.name);

} else {

chrome.send('extensionSettingsOptions', [extension.id]);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »