Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 49153006: Have ContainerNodeAlgorithms deal with references instead of pointers (Closed)

Created:
7 years, 1 month ago by Inactive
Modified:
7 years, 1 month ago
Reviewers:
adamk
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, eae+blinkwatch, dglazkov+blink, f(malita), adamk+blink_chromium.org, pdr, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Have ContainerNodeAlgorithms deal with references instead of pointers Have ContainerNodeAlgorithms deal with references instead of pointers since those can never be null. This makes the code look safer. R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160769

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -188 lines) Patch
M Source/core/dom/ContainerNode.h View 4 chunks +9 lines, -9 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 15 chunks +65 lines, -65 lines 1 comment Download
M Source/core/dom/ContainerNodeAlgorithms.h View 7 chunks +66 lines, -65 lines 0 comments Download
M Source/core/dom/ContainerNodeAlgorithms.cpp View 1 chunk +27 lines, -27 lines 0 comments Download
M Source/core/dom/Element.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/shadow/ElementShadow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ElementShadow.cpp View 3 chunks +10 lines, -9 lines 0 comments Download
M Source/core/html/parser/HTMLConstructionSite.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGElementInstance.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGElementInstance.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/xml/XMLErrors.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
7 years, 1 month ago (2013-10-28 19:46:47 UTC) #1
adamk
lgtm https://codereview.chromium.org/49153006/diff/1/Source/core/dom/ContainerNode.cpp File Source/core/dom/ContainerNode.cpp (right): https://codereview.chromium.org/49153006/diff/1/Source/core/dom/ContainerNode.cpp#newcode606 Source/core/dom/ContainerNode.cpp:606: ASSERT(*it); All these ASSERT(*it) calls make me wonder ...
7 years, 1 month ago (2013-10-28 21:41:12 UTC) #2
Inactive
On 2013/10/28 21:41:12, adamk wrote: > lgtm > > https://codereview.chromium.org/49153006/diff/1/Source/core/dom/ContainerNode.cpp > File Source/core/dom/ContainerNode.cpp (right): > ...
7 years, 1 month ago (2013-10-28 23:03:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/49153006/1
7 years, 1 month ago (2013-10-28 23:05:22 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-10-29 00:25:14 UTC) #5
Message was sent while issue was closed.
Change committed as 160769

Powered by Google App Engine
This is Rietveld 408576698