Source/core/xml/XMLErrors.cpp - Issue 49153006: Have ContainerNodeAlgorithms deal with references instead of pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xml/XMLErrors.cpp

Issue 49153006: Have ContainerNodeAlgorithms deal with references instead of pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/xml/XMLErrors.cpp

diff --git a/Source/core/xml/XMLErrors.cpp b/Source/core/xml/XMLErrors.cpp

index 26a6d1acd9d1976856bf949a31865d8537e6cc01..caad7f03667d2372f86cb476a6179f183872a84b 100644

--- a/Source/core/xml/XMLErrors.cpp

+++ b/Source/core/xml/XMLErrors.cpp

@@ -129,7 +129,7 @@ void XMLErrors::insertErrorMessageBlock()

RefPtr<Element> body = m_document->createElement(bodyTag, true);

rootElement->parserAppendChild(body);

- m_document->parserRemoveChild(documentElement.get());

+ m_document->parserRemoveChild(*documentElement);

body->parserAppendChild(documentElement);

m_document->parserAppendChild(rootElement);

« Source/core/dom/ContainerNode.cpp ('K') | « Source/core/svg/SVGElementInstance.cpp ('k') | no next file » | no next file with comments »