mojo/shell/in_process_dynamic_service_runner.h - Issue 491443005: Get rid of KeepAlive. Quit shell when all urls run directly by Context are closed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/shell/in_process_dynamic_service_runner.h

Issue 491443005: Get rid of KeepAlive. Quit shell when all urls run directly by Context are closed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Bring back ConnectToServiceViaNetwork Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/shell/dynamic_application_loader.cc ('K') | « mojo/shell/dynamic_application_loader_unittest.cc ('k') | mojo/shell/in_process_dynamic_service_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/shell/in_process_dynamic_service_runner.h

diff --git a/mojo/shell/in_process_dynamic_service_runner.h b/mojo/shell/in_process_dynamic_service_runner.h

index 3c72db31064228a6d3ab79d21f61194d50261da8..699428e75bdf711320fd7c731d64c96ca6b4e027 100644

--- a/mojo/shell/in_process_dynamic_service_runner.h

+++ b/mojo/shell/in_process_dynamic_service_runner.h

@@ -11,7 +11,6 @@

#include "base/scoped_native_library.h"

#include "base/threading/simple_thread.h"

#include "mojo/shell/dynamic_service_runner.h"

-#include "mojo/shell/keep_alive.h"

namespace mojo {

namespace shell {

@@ -34,7 +33,6 @@ class InProcessDynamicServiceRunner

// |base::DelegateSimpleThread::Delegate| method:

virtual void Run() OVERRIDE;

- KeepAlive keep_alive_;

base::FilePath app_path_;

ScopedMessagePipeHandle service_handle_;

base::Callback<bool(void)> app_completed_callback_runner_;