Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: mojo/shell/in_process_dynamic_service_runner.h

Issue 491443005: Get rid of KeepAlive. Quit shell when all urls run directly by Context are closed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Bring back ConnectToServiceViaNetwork Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_SHELL_IN_PROCESS_DYNAMIC_SERVICE_RUNNER_H_ 5 #ifndef MOJO_SHELL_IN_PROCESS_DYNAMIC_SERVICE_RUNNER_H_
6 #define MOJO_SHELL_IN_PROCESS_DYNAMIC_SERVICE_RUNNER_H_ 6 #define MOJO_SHELL_IN_PROCESS_DYNAMIC_SERVICE_RUNNER_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "base/scoped_native_library.h" 11 #include "base/scoped_native_library.h"
12 #include "base/threading/simple_thread.h" 12 #include "base/threading/simple_thread.h"
13 #include "mojo/shell/dynamic_service_runner.h" 13 #include "mojo/shell/dynamic_service_runner.h"
14 #include "mojo/shell/keep_alive.h"
15 14
16 namespace mojo { 15 namespace mojo {
17 namespace shell { 16 namespace shell {
18 17
19 // An implementation of |DynamicServiceRunner| that loads/runs the given app 18 // An implementation of |DynamicServiceRunner| that loads/runs the given app
20 // (from the file system) on a separate thread (in the current process). 19 // (from the file system) on a separate thread (in the current process).
21 class InProcessDynamicServiceRunner 20 class InProcessDynamicServiceRunner
22 : public DynamicServiceRunner, 21 : public DynamicServiceRunner,
23 public base::DelegateSimpleThread::Delegate { 22 public base::DelegateSimpleThread::Delegate {
24 public: 23 public:
25 explicit InProcessDynamicServiceRunner(Context* context); 24 explicit InProcessDynamicServiceRunner(Context* context);
26 virtual ~InProcessDynamicServiceRunner(); 25 virtual ~InProcessDynamicServiceRunner();
27 26
28 // |DynamicServiceRunner| method: 27 // |DynamicServiceRunner| method:
29 virtual void Start(const base::FilePath& app_path, 28 virtual void Start(const base::FilePath& app_path,
30 ScopedMessagePipeHandle service_handle, 29 ScopedMessagePipeHandle service_handle,
31 const base::Closure& app_completed_callback) OVERRIDE; 30 const base::Closure& app_completed_callback) OVERRIDE;
32 31
33 private: 32 private:
34 // |base::DelegateSimpleThread::Delegate| method: 33 // |base::DelegateSimpleThread::Delegate| method:
35 virtual void Run() OVERRIDE; 34 virtual void Run() OVERRIDE;
36 35
37 KeepAlive keep_alive_;
38 base::FilePath app_path_; 36 base::FilePath app_path_;
39 ScopedMessagePipeHandle service_handle_; 37 ScopedMessagePipeHandle service_handle_;
40 base::Callback<bool(void)> app_completed_callback_runner_; 38 base::Callback<bool(void)> app_completed_callback_runner_;
41 39
42 base::ScopedNativeLibrary app_library_; 40 base::ScopedNativeLibrary app_library_;
43 scoped_ptr<base::DelegateSimpleThread> thread_; 41 scoped_ptr<base::DelegateSimpleThread> thread_;
44 42
45 DISALLOW_COPY_AND_ASSIGN(InProcessDynamicServiceRunner); 43 DISALLOW_COPY_AND_ASSIGN(InProcessDynamicServiceRunner);
46 }; 44 };
47 45
48 typedef DynamicServiceRunnerFactoryImpl<InProcessDynamicServiceRunner> 46 typedef DynamicServiceRunnerFactoryImpl<InProcessDynamicServiceRunner>
49 InProcessDynamicServiceRunnerFactory; 47 InProcessDynamicServiceRunnerFactory;
50 48
51 } // namespace shell 49 } // namespace shell
52 } // namespace mojo 50 } // namespace mojo
53 51
54 #endif // MOJO_SHELL_IN_PROCESS_DYNAMIC_SERVICE_RUNNER_H_ 52 #endif // MOJO_SHELL_IN_PROCESS_DYNAMIC_SERVICE_RUNNER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698