SkMultiPictureDraw API

SkMultiPictureDraw API

This CL adds a new API to optimize across multiple SkPicture draw calls.

Note that multiple pictures rendered at once (i.e., picture piles) should be flattened into a single new picture that includes the required clipping on the different layers.

Committed: https://skia.googlesource.com/skia/+/7eacd77ce63abec6c5a0e7be9bf9f40ea4145d11

[bsalomon, 2014-08-21 14:49:32]

https://codereview.chromium.org/491313003/diff/1/include/core/SkMultiPictureD...
File include/core/SkMultiPictureDraw.h (right):

https://codereview.chromium.org/491313003/diff/1/include/core/SkMultiPictureD...
include/core/SkMultiPictureDraw.h:36: void add(const SkPicture* picture,
Do we really need this?

https://codereview.chromium.org/491313003/diff/1/include/core/SkMultiPictureD...
include/core/SkMultiPictureDraw.h:56: ClipType clipType;
Doesn't rrect know if it's a rect?

[robertphillips, 2014-08-21 17:14:32]

PTAL

[reed1, 2014-08-21 17:58:01]

api lgtm w/ nit about arg

https://codereview.chromium.org/491313003/diff/40001/include/core/SkMultiPict...
File include/core/SkMultiPictureDraw.h (right):

https://codereview.chromium.org/491313003/diff/40001/include/core/SkMultiPict...
include/core/SkMultiPictureDraw.h:26: SkMultiPictureDraw(int sizeHint = 0);
document or remove

[bsalomon, 2014-08-21 17:58:40]

https://codereview.chromium.org/491313003/diff/40001/include/core/SkMultiPict...
File include/core/SkMultiPictureDraw.h (right):

https://codereview.chromium.org/491313003/diff/40001/include/core/SkMultiPict...
include/core/SkMultiPictureDraw.h:26: SkMultiPictureDraw(int sizeHint = 0);
wonder if we should call this reserve to be consistent with SkT(D)Array?

https://codereview.chromium.org/491313003/diff/40001/include/core/SkMultiPict...
include/core/SkMultiPictureDraw.h:26: SkMultiPictureDraw(int sizeHint = 0);
wonder if we should call this reserve to be consistent with SkT(D)Array?

https://codereview.chromium.org/491313003/diff/40001/src/core/SkMultiPictureD...
File src/core/SkMultiPictureDraw.cpp (right):

https://codereview.chromium.org/491313003/diff/40001/src/core/SkMultiPictureD...
src/core/SkMultiPictureDraw.cpp:18: void SkMultiPictureDraw::unrefAll() {
reset()? clear()? 

Maybe this should be public? It seems potentially useful and safe to expose.

[robertphillips, 2014-08-21 18:21:35]

https://codereview.chromium.org/491313003/diff/40001/include/core/SkMultiPict...
File include/core/SkMultiPictureDraw.h (right):

https://codereview.chromium.org/491313003/diff/40001/include/core/SkMultiPict...
include/core/SkMultiPictureDraw.h:26: SkMultiPictureDraw(int sizeHint = 0);
On 2014/08/21 17:58:01, reed1 wrote:
> document or remove

Done.

https://codereview.chromium.org/491313003/diff/40001/include/core/SkMultiPict...
include/core/SkMultiPictureDraw.h:26: SkMultiPictureDraw(int sizeHint = 0);
On 2014/08/21 17:58:40, bsalomon wrote:
> wonder if we should call this reserve to be consistent with SkT(D)Array?

Done.

https://codereview.chromium.org/491313003/diff/40001/src/core/SkMultiPictureD...
File src/core/SkMultiPictureDraw.cpp (right):

https://codereview.chromium.org/491313003/diff/40001/src/core/SkMultiPictureD...
src/core/SkMultiPictureDraw.cpp:18: void SkMultiPictureDraw::unrefAll() {
On 2014/08/21 17:58:40, bsalomon wrote:
> reset()? clear()? 
> 
> Maybe this should be public? It seems potentially useful and safe to expose.

Done - as reset.

[bsalomon, 2014-08-21 18:23:47]

lgtm

[robertphillips, 2014-08-21 18:24:47]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-08-21 18:25:34]

CQ is trying da patch. Follow status at

https://skia-tree-status.appspot.com/cq/robertphillips@google.com/491313003/8...

[commit-bot: I haz the power, 2014-08-21 18:31:59]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Try...)

[commit-bot: I haz the power, 2014-08-21 18:35:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-21 18:35:29]

Try jobs failed on following builders:
  Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Try...)

[robertphillips, 2014-08-21 19:13:24]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-08-21 19:13:40]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/robertphillips@google.com/491313003/2

[commit-bot: I haz the power, 2014-08-21 20:12:47]

Committed patchset #6 (2) as 7eacd77ce63abec6c5a0e7be9bf9f40ea4145d11