Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 491057: ChromeFrame's host network stack implementation for IE should ensure that HTT... (Closed)

Created:
11 years ago by ananta
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, amit
Visibility:
Public.

Description

ChromeFrame's host network stack implementation for IE should ensure that HTTP requests issued by Chrome which terminate without any data complete correctly, i.e. we send over the request end notification to Chrome. This ensures that Chrome does not wait forever for the request to complete. This fixes http://code.google.com/p/chromium/issues/detail?id=30149, which shows up on certain sites where the throbber continues to spin at times and at times pages show up blank. Bug=30149 Test=Launch ChromeFrame in IE and navigate to cf:http://www.tennisballcricket.org. We should not see a blank page. Will look into a unit test for this. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34400

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome_frame/urlmon_url_request.cc View 1 2 3 3 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ananta
11 years ago (2009-12-11 20:28:43 UTC) #1
tommi (sloooow) - chröme
nice find. lgtm http://codereview.chromium.org/491057/diff/1002/1003 File chrome_frame/urlmon_url_request.cc (right): http://codereview.chromium.org/491057/diff/1002/1003#newcode247 chrome_frame/urlmon_url_request.cc:247: if (pending_read_size_) { add a comment?
11 years ago (2009-12-11 20:44:06 UTC) #2
ananta
11 years ago (2009-12-11 21:34:32 UTC) #3
http://codereview.chromium.org/491057/diff/1002/1003
File chrome_frame/urlmon_url_request.cc (right):

http://codereview.chromium.org/491057/diff/1002/1003#newcode247
chrome_frame/urlmon_url_request.cc:247: if (pending_read_size_) {
On 2009/12/11 20:44:06, tommi wrote:
> add a comment?

Done.

Powered by Google App Engine
This is Rietveld 408576698