ChromeFrame's host network stack implementation for IE should ensure that HTT...

chrome_frame/urlmon_url_request.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome_frame/urlmon_url_request.h"
 
 #include <wininet.h>
 
 #include "base/scoped_ptr.h"
 #include "base/string_util.h"
@@ skipping 196 matching lines @@
                  << status_text;
       redirect_url_ = status_text;
       redirect_status_ =
           redirect_status > 0 ? redirect_status : kDefaultHttpRedirectCode;
       // Chrome should decide whether a redirect has to be followed. To achieve
       // this we send over a fake response to Chrome and abort the redirect.
       std::string headers = GetHttpHeaders();
       OnResponse(0, UTF8ToWide(headers).c_str(), NULL, NULL);
       ignore_redirect_stop_binding_error_ = true;
       DCHECK(binding_ != NULL);
-      binding_->Abort();
-      binding_ = NULL;
+      if (binding_) {
+        binding_->Abort();
+        binding_ = NULL;
+      }
       return E_ABORT;
     }
 
     default:
       DLOG(INFO) << " Obj: " << std::hex << this << " OnProgress(" << url()
           << StringPrintf(L") code: %i status: %ls", status_code, status_text);
       break;
   }
 
   return S_OK;
 }
 
 STDMETHODIMP UrlmonUrlRequest::OnStopBinding(HRESULT result, LPCWSTR error) {
   DCHECK(worker_thread_ != NULL);
   DCHECK_EQ(PlatformThread::CurrentId(), worker_thread_->thread_id());
 
   DLOG(INFO) << StringPrintf("URL: %s Obj: %X", url().c_str(), this) <<
       " - Request stopped, Result: " << std::hex << result <<
       " Status: " << status_.status();
 
   if (FAILED(result)) {
     status_.set_status(URLRequestStatus::FAILED);
     status_.set_os_error(HresultToNetError(result));
     EndRequest();
   } else {
     status_.set_status(URLRequestStatus::SUCCESS);
     status_.set_os_error(0);
     ReleaseBindings();
+    // In most cases we receive the end request notification from Chrome.
+    // However at times requests can complete without us receiving any
+    // data. In this case we need to inform Chrome that this request has been
+    // completed to prevent Chrome from waiting forever for data for this
+    // request.
+    if (!cached_data_.is_valid()) {
+      pending_read_size_ = 0;
+      OnResponseEnd(status_);
+    }
   }
 
   return S_OK;
 }
 
 STDMETHODIMP UrlmonUrlRequest::GetBindInfo(DWORD* bind_flags,
     BINDINFO *bind_info) {
   DCHECK(worker_thread_ != NULL);
   DCHECK_EQ(PlatformThread::CurrentId(), worker_thread_->thread_id());
 
@@ skipping 68 matching lines @@
   cached_data_.Append(read_stream, &bytes_available);
   DLOG(INFO) << StringPrintf("URL: %s Obj: %X", url().c_str(), this) <<
       " -  Bytes read into cache: " << bytes_available;
 
   if (pending_read_size_ && cached_data_.is_valid()) {
     CComObjectStackEx<SendStream> send_stream;
     send_stream.Initialize(this);
     cached_data_.Read(&send_stream, pending_read_size_, &pending_read_size_);
     DLOG(INFO) << StringPrintf("URL: %s Obj: %X", url().c_str(), this) <<
         " - size read: " << pending_read_size_;
+    pending_read_size_ = 0;
   } else {
     DLOG(INFO) << StringPrintf("URL: %s Obj: %X", url().c_str(), this) <<
         " - waiting for remote read";
   }
 
   if (BSCF_LASTDATANOTIFICATION & flags) {
     status_.set_status(URLRequestStatus::SUCCESS);
     DLOG(INFO) << StringPrintf("URL: %s Obj: %X", url().c_str(), this) <<
         " - end of data.";
   }
@@ skipping 478 matching lines @@
       ret = net::ERR_ACCESS_DENIED;
       break;
 
     default:
       DLOG(WARNING)
           << StringPrintf("TODO: translate HRESULT 0x%08X to net::Error", hr);
       break;
   }
   return ret;
 }