Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 491023002: Get rid of all non-IC uses of LookupOwnRealNamedProperty (Closed)

Created:
6 years, 4 months ago by Toon Verwaest
Modified:
6 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Get rid of all non-IC uses of LookupOwnRealNamedProperty BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23262

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -35 lines) Patch
M src/lookup-inl.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/objects.cc View 3 chunks +13 lines, -33 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -1 line 3 comments Download

Messages

Total messages: 5 (0 generated)
Toon Verwaest
PTAL
6 years, 4 months ago (2014-08-20 15:04:58 UTC) #1
Yang
https://codereview.chromium.org/491023002/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (left): https://codereview.chromium.org/491023002/diff/1/test/cctest/test-api.cc#oldcode21727 test/cctest/test-api.cc:21727: context0->Global()->Set(v8_str("x"), v8_num(42)); Is this intentional? Why?
6 years, 4 months ago (2014-08-21 06:08:20 UTC) #2
Toon Verwaest
https://codereview.chromium.org/491023002/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (left): https://codereview.chromium.org/491023002/diff/1/test/cctest/test-api.cc#oldcode21727 test/cctest/test-api.cc:21727: context0->Global()->Set(v8_str("x"), v8_num(42)); On 2014/08/21 06:08:20, Yang wrote: > Is ...
6 years, 4 months ago (2014-08-21 07:02:55 UTC) #3
Yang
LGTM https://codereview.chromium.org/491023002/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (left): https://codereview.chromium.org/491023002/diff/1/test/cctest/test-api.cc#oldcode21727 test/cctest/test-api.cc:21727: context0->Global()->Set(v8_str("x"), v8_num(42)); On 2014/08/21 07:02:55, Toon Verwaest wrote: ...
6 years, 4 months ago (2014-08-21 07:37:26 UTC) #4
Toon Verwaest
6 years, 4 months ago (2014-08-21 08:26:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as 23262 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698