Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: test/cctest/test-api.cc

Issue 491023002: Get rid of all non-IC uses of LookupOwnRealNamedProperty (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index 50ce753db869947089012d42c9710ace2ac70818..73d39cea8dc03c7f7b0359e492eb1e59d7d5c721 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -21724,7 +21724,6 @@ TEST(AccessCheckThrows) {
// Create a context and set an x property on it's global object.
LocalContext context0(NULL, global_template);
- context0->Global()->Set(v8_str("x"), v8_num(42));
Yang 2014/08/21 06:08:20 Is this intentional? Why?
Toon Verwaest 2014/08/21 07:02:55 Because below it's calling into %AddNamedProperty,
Yang 2014/08/21 07:37:26 Acknowledged.
v8::Handle<v8::Object> global0 = context0->Global();
// Create a context with a different security token so that the
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698