Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 490983004: [WIP]Move GeolocationClient to the Oilpan heap. (Closed)

Created:
6 years, 4 months ago by sof
Modified:
6 years, 4 months ago
Reviewers:
CC:
blink-reviews, mvanouwerkerk+watch_chromium.org, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[WIP]Move GeolocationClient to the Oilpan heap. R= BUG=

Patch Set 1 #

Patch Set 2 : Reinstate willBeDestroyed over Supplement(able) #

Patch Set 3 : Non-Oilpan compile fixes #

Patch Set 4 : Remove willBeDestroyed over Supplement(able) #

Patch Set 5 : GeolocationController's client must now be a Member #

Patch Set 6 : Remove GeolocationController::detach() #

Patch Set 7 : Remove GeolocationClient::geolocationDestroyed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -65 lines) Patch
M Source/core/page/Page.cpp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/geolocation/GeolocationClient.h View 1 2 3 4 5 6 3 chunks +5 lines, -4 lines 0 comments Download
M Source/modules/geolocation/GeolocationController.h View 1 2 3 4 5 2 chunks +1 line, -4 lines 0 comments Download
M Source/modules/geolocation/GeolocationController.cpp View 1 2 3 4 5 2 chunks +2 lines, -17 lines 0 comments Download
M Source/modules/geolocation/testing/GeolocationClientMock.h View 1 2 3 4 5 6 4 chunks +9 lines, -6 lines 0 comments Download
M Source/modules/geolocation/testing/GeolocationClientMock.cpp View 1 2 3 4 5 6 2 chunks +10 lines, -5 lines 0 comments Download
M Source/platform/Supplementable.h View 2 3 2 chunks +0 lines, -9 lines 0 comments Download
M Source/web/GeolocationClientProxy.h View 1 2 3 4 5 6 2 chunks +10 lines, -3 lines 0 comments Download
M Source/web/GeolocationClientProxy.cpp View 1 2 3 4 5 6 2 chunks +6 lines, -6 lines 0 comments Download
M Source/web/WebLocalFrameImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 2 2 chunks +1 line, -9 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698