Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1404)

Unified Diff: tests/lib/mirrors/generic_bounded_test.dart

Issue 49083004: Re-triage mirror test failures on the analyzer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/lib/mirrors/generic_bounded_test.dart
diff --git a/tests/lib/mirrors/generic_bounded_test.dart b/tests/lib/mirrors/generic_bounded_test.dart
index c59d3af56096e8e984b2a2e86a33f0c620bf2418..dec144aebd5989affc77f45d5ab714c8ce6ef15d 100644
--- a/tests/lib/mirrors/generic_bounded_test.dart
+++ b/tests/lib/mirrors/generic_bounded_test.dart
@@ -8,57 +8,57 @@ import 'dart:mirrors';
import 'package:expect/expect.dart';
-import 'generics_test.dart';
+import 'generics_helper.dart';
class Super<T extends num> {}
class Fixed extends Super<int> {}
-class Generic<R> extends Super<R> {}
+class Generic<R> extends Super<R> {} /// 02: static type warning
class Malbounded extends Super<String> {} /// 01: static type warning
main() {
ClassMirror superDecl = reflectClass(Super);
ClassMirror superOfInt = reflectClass(Fixed).superclass;
- ClassMirror genericDecl = reflectClass(Generic);
- ClassMirror superOfR = genericDecl.superclass;
- ClassMirror genericOfDouble = reflect(new Generic<double>()).type;
- ClassMirror superOfDouble = genericOfDouble.superclass;
+ ClassMirror genericDecl = reflectClass(Generic); /// 02: continued
+ ClassMirror superOfR = genericDecl.superclass; /// 02: continued
+ ClassMirror genericOfDouble = reflect(new Generic<double>()).type; /// 02: continued
+ ClassMirror superOfDouble = genericOfDouble.superclass; /// 02: continued
ClassMirror genericOfBool = reflect(new Generic<bool>()).type; /// 02: static type warning, dynamic type error
ClassMirror superOfBool = genericOfBool.superclass; /// 02: continued
ClassMirror superOfString = reflectClass(Malbounded).superclass; /// 01: continued
Expect.isTrue(superDecl.isOriginalDeclaration);
Expect.isFalse(superOfInt.isOriginalDeclaration);
- Expect.isTrue(genericDecl.isOriginalDeclaration);
- Expect.isFalse(superOfR.isOriginalDeclaration);
- Expect.isFalse(genericOfDouble.isOriginalDeclaration);
- Expect.isFalse(superOfDouble.isOriginalDeclaration);
+ Expect.isTrue(genericDecl.isOriginalDeclaration); /// 02: continued
+ Expect.isFalse(superOfR.isOriginalDeclaration); /// 02: continued
+ Expect.isFalse(genericOfDouble.isOriginalDeclaration); /// 02: continued
+ Expect.isFalse(superOfDouble.isOriginalDeclaration); /// 02: continued
Expect.isFalse(genericOfBool.isOriginalDeclaration); /// 02: continued
Expect.isFalse(superOfBool.isOriginalDeclaration); /// 02: continued
Expect.isFalse(superOfString.isOriginalDeclaration); /// 01: continued
TypeVariableMirror tFromSuper = superDecl.typeVariables.single;
- TypeVariableMirror rFromGeneric = genericDecl.typeVariables.single;
+ TypeVariableMirror rFromGeneric = genericDecl.typeVariables.single; /// 02: continued
Expect.equals(reflectClass(num), tFromSuper.upperBound);
- Expect.equals(reflectClass(Object), rFromGeneric.upperBound);
+ Expect.equals(reflectClass(Object), rFromGeneric.upperBound); /// 02: continued
typeParameters(superDecl, [#T]);
typeParameters(superOfInt, [#T]);
- typeParameters(genericDecl, [#R]);
- typeParameters(superOfR, [#T]);
- typeParameters(genericOfDouble, [#R]);
- typeParameters(superOfDouble, [#T]);
+ typeParameters(genericDecl, [#R]); /// 02: continued
+ typeParameters(superOfR, [#T]); /// 02: continued
+ typeParameters(genericOfDouble, [#R]); /// 02: continued
+ typeParameters(superOfDouble, [#T]); /// 02: continued
typeParameters(genericOfBool, [#R]); /// 02: continued
typeParameters(superOfBool, [#T]); /// 02: continued
typeParameters(superOfString, [#T]); /// 01: continued
typeArguments(superDecl, []);
typeArguments(superOfInt, [reflectClass(int)]);
- typeArguments(genericDecl, []);
- typeArguments(superOfR, [rFromGeneric]);
- typeArguments(genericOfDouble, [reflectClass(double)]);
- typeArguments(superOfDouble, [reflectClass(double)]);
+ typeArguments(genericDecl, []); /// 02: continued
+ typeArguments(superOfR, [rFromGeneric]); /// 02: continued
+ typeArguments(genericOfDouble, [reflectClass(double)]); /// 02: continued
+ typeArguments(superOfDouble, [reflectClass(double)]); /// 02: continued
typeArguments(genericOfBool, [reflectClass(bool)]); /// 02: continued
typeArguments(superOfBool, [reflectClass(bool)]); /// 02: continued
typeArguments(superOfString, [reflectClass(String)]); /// 01: continued

Powered by Google App Engine
This is Rietveld 408576698