Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: tests/lib/mirrors/generic_bounded_by_type_parameter_test.dart

Issue 49083004: Re-triage mirror test failures on the analyzer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/mirrors/equality_test.dart ('k') | tests/lib/mirrors/generic_bounded_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/generic_bounded_by_type_parameter_test.dart
diff --git a/tests/lib/mirrors/generic_bounded_by_type_parameter_test.dart b/tests/lib/mirrors/generic_bounded_by_type_parameter_test.dart
index 2391aa5153b66d52663a1028432d67d9b2265451..c6f2b1698255c8228bb1564ab33e0cc291acd999 100644
--- a/tests/lib/mirrors/generic_bounded_by_type_parameter_test.dart
+++ b/tests/lib/mirrors/generic_bounded_by_type_parameter_test.dart
@@ -8,61 +8,61 @@ import 'dart:mirrors';
import 'package:expect/expect.dart';
-import 'generics_test.dart';
+import 'generics_helper.dart';
class Super<T, R extends T> {}
class Fixed extends Super<num, int> {}
-class Generic<X, Y> extends Super<X, Y> {}
+class Generic<X, Y> extends Super<X, Y> {} /// 02: static type warning
class Malbounded extends Super<num, String> {} /// 01: static type warning
main() {
ClassMirror superDecl = reflectClass(Super);
ClassMirror superOfNumAndInt = reflectClass(Fixed).superclass;
- ClassMirror genericDecl = reflectClass(Generic);
- ClassMirror superOfXAndY = genericDecl.superclass;
- ClassMirror genericOfNumAndDouble = reflect(new Generic<num, double>()).type;
- ClassMirror superOfNumAndDouble = genericOfNumAndDouble.superclass;
+ ClassMirror genericDecl = reflectClass(Generic); /// 02: continued
+ ClassMirror superOfXAndY = genericDecl.superclass; /// 02: continued
+ ClassMirror genericOfNumAndDouble = reflect(new Generic<num, double>()).type; /// 02: continued
+ ClassMirror superOfNumAndDouble = genericOfNumAndDouble.superclass; /// 02: continued
ClassMirror genericOfNumAndBool = reflect(new Generic<num, bool>()).type; /// 02: static type warning, dynamic type error
ClassMirror superOfNumAndBool = genericOfNumAndBool.superclass; /// 02: continued
ClassMirror superOfNumAndString = reflectClass(Malbounded).superclass; /// 01: continued
Expect.isTrue(superDecl.isOriginalDeclaration);
Expect.isFalse(superOfNumAndInt.isOriginalDeclaration);
- Expect.isTrue(genericDecl.isOriginalDeclaration);
- Expect.isFalse(superOfXAndY.isOriginalDeclaration);
- Expect.isFalse(genericOfNumAndDouble.isOriginalDeclaration);
- Expect.isFalse(superOfNumAndDouble.isOriginalDeclaration);
+ Expect.isTrue(genericDecl.isOriginalDeclaration); /// 02: continued
+ Expect.isFalse(superOfXAndY.isOriginalDeclaration); /// 02: continued
+ Expect.isFalse(genericOfNumAndDouble.isOriginalDeclaration); /// 02: continued
+ Expect.isFalse(superOfNumAndDouble.isOriginalDeclaration); /// 02: continued
Expect.isFalse(genericOfNumAndBool.isOriginalDeclaration); /// 02: continued
Expect.isFalse(superOfNumAndBool.isOriginalDeclaration); /// 02: continued
Expect.isFalse(superOfNumAndString.isOriginalDeclaration); /// 01: continued
TypeVariableMirror tFromSuper = superDecl.typeVariables[0];
TypeVariableMirror rFromSuper = superDecl.typeVariables[1];
- TypeVariableMirror xFromGeneric = genericDecl.typeVariables[0];
- TypeVariableMirror yFromGeneric = genericDecl.typeVariables[1];
+ TypeVariableMirror xFromGeneric = genericDecl.typeVariables[0]; /// 02: continued
+ TypeVariableMirror yFromGeneric = genericDecl.typeVariables[1]; /// 02: continued
Expect.equals(reflectClass(Object), tFromSuper.upperBound);
Expect.equals(tFromSuper, rFromSuper.upperBound);
- Expect.equals(reflectClass(Object), xFromGeneric.upperBound);
- Expect.equals(reflectClass(Object), yFromGeneric.upperBound);
+ Expect.equals(reflectClass(Object), xFromGeneric.upperBound); /// 02: continued
+ Expect.equals(reflectClass(Object), yFromGeneric.upperBound); /// 02: continued
typeParameters(superDecl, [#T, #R]);
typeParameters(superOfNumAndInt, [#T, #R]);
- typeParameters(genericDecl, [#X, #Y]);
- typeParameters(superOfXAndY, [#T, #R]);
- typeParameters(genericOfNumAndDouble, [#X, #Y]);
- typeParameters(superOfNumAndDouble, [#T, #R]);
+ typeParameters(genericDecl, [#X, #Y]); /// 02: continued
+ typeParameters(superOfXAndY, [#T, #R]); /// 02: continued
+ typeParameters(genericOfNumAndDouble, [#X, #Y]); /// 02: continued
+ typeParameters(superOfNumAndDouble, [#T, #R]); /// 02: continued
typeParameters(genericOfNumAndBool, [#X, #Y]); /// 02: continued
typeParameters(superOfNumAndBool, [#T, #R]); /// 02: continued
typeParameters(superOfNumAndString, [#T, #R]); /// 01: continued
typeArguments(superDecl, []);
typeArguments(superOfNumAndInt, [reflectClass(num), reflectClass(int)]);
- typeArguments(genericDecl, []);
- typeArguments(superOfXAndY, [xFromGeneric, yFromGeneric]);
- typeArguments(genericOfNumAndDouble, [reflectClass(num), reflectClass(double)]);
- typeArguments(superOfNumAndDouble, [reflectClass(num), reflectClass(double)]);
+ typeArguments(genericDecl, []); /// 02: continued
+ typeArguments(superOfXAndY, [xFromGeneric, yFromGeneric]); /// 02: continued
+ typeArguments(genericOfNumAndDouble, [reflectClass(num), reflectClass(double)]); /// 02: continued
+ typeArguments(superOfNumAndDouble, [reflectClass(num), reflectClass(double)]); /// 02: continued
typeArguments(genericOfNumAndBool, [reflectClass(num), reflectClass(bool)]); /// 02: continued
typeArguments(superOfNumAndBool, [reflectClass(num), reflectClass(bool)]); /// 02: continued
typeArguments(superOfNumAndString, [reflectClass(num), reflectClass(String)]); /// 01: continued
« no previous file with comments | « tests/lib/mirrors/equality_test.dart ('k') | tests/lib/mirrors/generic_bounded_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698