Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 490813002: Fix the string resource paths in check_grd_unused_strings.py. (Closed)

Created:
6 years, 4 months ago by JungJik
Modified:
6 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix the string resource paths in check_grd_unused_strings.py. string resource paths has been changed. but we did not update them in check_grd_unused_strings.py. this is a patch for updating the current resource path. Bug=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290995

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/tools/check_grd_for_unused_strings.py View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
JungJik
PTAL :)
6 years, 4 months ago (2014-08-20 02:51:17 UTC) #1
sky
LGTM
6 years, 4 months ago (2014-08-20 15:19:11 UTC) #2
JungJik
The CQ bit was checked by jungjik.lee@samsung.com
6 years, 4 months ago (2014-08-20 23:22:20 UTC) #3
JungJik
On 2014/08/20 15:19:11, sky wrote: > LGTM thanks for LGTM :)
6 years, 4 months ago (2014-08-20 23:22:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/490813002/1
6 years, 4 months ago (2014-08-20 23:24:03 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-21 00:48:37 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 00:51:22 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/55367)
6 years, 4 months ago (2014-08-21 00:51:22 UTC) #8
JungJik
The CQ bit was checked by jungjik.lee@samsung.com
6 years, 4 months ago (2014-08-21 01:46:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/490813002/1
6 years, 4 months ago (2014-08-21 01:48:23 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-21 01:51:53 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 01:55:13 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/55458)
6 years, 4 months ago (2014-08-21 01:55:14 UTC) #13
JungJik
The CQ bit was checked by jungjik.lee@samsung.com
6 years, 4 months ago (2014-08-21 04:21:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/490813002/1
6 years, 4 months ago (2014-08-21 04:23:28 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 04:29:24 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (1) as 290995

Powered by Google App Engine
This is Rietveld 408576698